After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546747 - program won't restart even set X-GNOME-AutoRestart=true
program won't restart even set X-GNOME-AutoRestart=true
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
2.23.x
Other All
: Normal major
: ---
Assigned To: Jonh Wendell
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-08-07 09:08 UTC by Halton Huo
Modified: 2008-09-01 16:04 UTC
See Also:
GNOME target: 2.24.x
GNOME version: 2.23/2.24


Attachments
autostart desktop file for vino-server (273 bytes, patch)
2008-08-07 09:12 UTC, Halton Huo
none Details | Review
Make vino a gnome-session client (15.68 KB, patch)
2008-08-29 14:04 UTC, Jonh Wendell
committed Details | Review

Description Halton Huo 2008-08-07 09:08:45 UTC
I'm using new gnome-session 2.23.6. Take vino for example:

With bug #544650 fixed, there is a vino-server.desktop file in /usr/share/gnome/autostart.

How to reproduce
1) Start vino-preferences to enable vino
2) Use 'ps -ef|grep vino-server' to confirm vino-server is running
3) pkill vino-server
4) Wait for a while, use 'ps -ef|grep vino-server' to check whether vino-server is running

Expected result:
   vino-server can restart after a while

Actual result:
   vino-server does not restart
Comment 1 Halton Huo 2008-08-07 09:12:08 UTC
Created attachment 116041 [details] [review]
autostart desktop file for vino-server

If you do not have bug #544650 included, put vino-server.desktop under /usr/share/gnome/autostart is alos okay.
Comment 2 William Jon McCann 2008-08-08 15:14:19 UTC
Looks like you have a hyphen where it should not be.  Try the following instead:
AutostartCondition=GNOME /desktop/gnome/remote_access/enabled

Does that work?
Comment 3 Jonh Wendell 2008-08-08 16:37:28 UTC
Hi, William.

It works in the sense it will start vino-server at login time. But it still doesn't restart vino-server if I kill it.
Comment 4 Halton Huo 2008-08-11 03:12:42 UTC
William, I got same result with John.

I checked in gnome-session code, it really lookups AutostartCondition instead of Autostart-Condition. This is inconsistent on document http://lists.freedesktop.org/archives/xdg/2007-January/007436.html.

Anyway, i'm going to change vino-server.desktop.in.in to use AutostartCondition.
Comment 5 William Jon McCann 2008-08-15 17:50:59 UTC
AutostartCondition is correct.  I've confirmed this with Dan.
Comment 6 Jonh Wendell 2008-08-15 18:03:11 UTC
Hi, Jon.

I didn't understand why this bug was closed.

We are using AutostartCondition=true and vino-server is not being restarted if it crashes (or I kill it).
Comment 7 William Jon McCann 2008-08-15 18:17:12 UTC
vino must become a client of the session manager for this key to have any effect.
Comment 8 Jonh Wendell 2008-08-29 14:04:49 UTC
Created attachment 117588 [details] [review]
Make vino a gnome-session client

With this patch I:

- dropped the bonobo stuff. Now gnome-session is responsible for [re]start/stop vino.
- made vino-server a gnome-session client
- made obsolete the directory "session/". (the configure option "--enable-session-support" doesn't exist anymore
Comment 9 Jonh Wendell 2008-08-29 14:08:45 UTC
I have tested this patch against gnome-session 2.23.90 and it worked fine, as expected, starting, stopping and restarting vino-server correctly.

I would like to commit this patch in time to 2.23.91, which is next Monday.

Mark, any comments?
Comment 10 Jonh Wendell 2008-09-01 16:04:02 UTC
okay, no comments so far, I just committed it to trunk. Will be available in 2.23.91.