After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546312 - Make the metadata writable before modifying it in rtpmanager
Make the metadata writable before modifying it in rtpmanager
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-04 20:22 UTC by Olivier Crête
Modified: 2008-08-05 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make the metadata writable before modifying it (2.22 KB, patch)
2008-08-04 20:23 UTC, Olivier Crête 		none Details | Review

Description Olivier Crête 2008-08-04 20:22:45 UTC 
gstrtpsession and gstrtpjitterbuffer modify the buffer metadata (respectively the offset and the timestamp) without making sure that no one else owns the buffer first.. Attached patch fixes that
Comment 1 Olivier Crête 2008-08-04 20:23:34 UTC 
Created attachment 115853 [details] [review]
make the metadata writable before modifying it
Comment 2 Wim Taymans 2008-08-05 09:42:51 UTC 
I added the calls in slightly different places.

        Based on patch by: Olivier Crete <tester at tester dot ca>

        * gst/rtpmanager/gstrtpjitterbuffer.c:
        (gst_rtp_jitter_buffer_chain), (gst_rtp_jitter_buffer_loop):
        Make the buffer metadata writable before inserting it in the
        jitterbuffer because the jitterbuffer will modify the timestamps.

        * gst/rtpmanager/rtpjitterbuffer.c:
        Update method comment about requiring writable metadata on buffers.

        * gst/rtpmanager/rtpsession.c: (rtp_session_process_sr),
        (rtp_session_process_rtcp):
        Make the RTCP buffer metadata writable because we want to modify the
        metadata.
        Fixes #546312.