After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544831 - Remove gnome-vfs dependency
Remove gnome-vfs dependency
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonoboui
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2008-07-26 12:06 UTC by Cosimo Cecchi
Modified: 2008-08-04 14:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
patch (2.03 KB, patch)
2008-07-26 12:08 UTC, Cosimo Cecchi 		none Details | Review
patch v2 (1.62 KB, patch)
2008-07-28 09:56 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2008-07-26 12:06:23 UTC 
Hi,

there's really no need for the gnome-vfs dependency in libbonoboui, and it seems that, for some modules like bug-buddy, libbonoboui is the last library pulling in gnome-vfs (many of the other libraries of the stack already moved away from it).
I'm attaching a patch that removes the dep.
Comment 1 Cosimo Cecchi 2008-07-26 12:08:18 UTC 
Created attachment 115311 [details] [review]
patch
Comment 2 Kjartan Maraas 2008-07-27 11:29:46 UTC 
pbor mentioned using g_filename_to_uri() instead of the homecooked function. Other than that are you ok with this michael?
Comment 3 Cosimo Cecchi 2008-07-28 09:56:36 UTC 
Created attachment 115417 [details] [review]
patch v2

Use g_filename_to_uri ().
Comment 4 Cosimo Cecchi 2008-08-04 14:10:04 UTC 
Committed to trunk.

2008-08-04  Cosimo Cecchi  <cosimoc@gnome.org>

	reviewed by: Michael Meeks <michael.meeks@novell.com>

	* bonobo/bonobo-file-selector-util.c: (run_file_selector):
	* configure.in:
	Remove gnome-vfs dependency (#544831).