Bug 543532 – Invalid writes when disable an account

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 543532 - Invalid writes when disable an account


Summary:	Invalid writes when disable an account


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Mailer
Version:	2.24.x (obsolete)
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Duplicates:	541461 (view as bug list)
Depends on:
Blocks:

Reported:	2008-07-18 04:35 UTC by Akhil Laddha
Modified:	2013-09-13 01:01 UTC

See Also:
GNOME target:	---
GNOME version:	2.21/2.22

Attachments
proposed evo patch (1.06 KB, patch) 2008-07-21 16:09 UTC, Milan Crha	committed	Details \| Review

Description Akhil Laddha 2008-07-18 04:35:23 UTC

Evolution 2.23.5 

I went to preference window and disabled the imap account, evolution showed some invalid writes.

==4426== 
==4426== Thread 1:
==4426== Invalid read of size 4
==4426==    at 0xA81D9F7: em_folder_tree_model_remove_folders (em-folder-tree-model.c:882)
==4426==    by 0xA81DDFE: em_folder_tree_model_remove_store (em-folder-tree-model.c:941)
==4426==    by 0xA81E613: account_changed (em-folder-tree-model.c:399)
==4426==    by 0x5979C69: g_cclosure_marshal_VOID__OBJECT (gmarshal.c:636)
==4426==    by 0x596BC2A: g_closure_invoke (gclosure.c:767)
==4426==    by 0x5983424: signal_emit_unlocked_R (gsignal.c:3256)
==4426==    by 0x5984B5F: g_signal_emit_valist (gsignal.c:2988)
==4426==    by 0x5984FE5: g_signal_emit (gsignal.c:3046)
==4426==    by 0x471AFD5: e_account_list_change (e-account-list.c:367)
==4426==    by 0xEBA9DF8: mail_account_disable (mail-account-disable.c:70)
==4426==    by 0x42548F1: ep_activate (e-popup.c:295)
==4426==    by 0x5979AE3: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==4426==  Address 0x5e49734 is 12 bytes inside a block of size 40 free'd
==4426==    at 0x4023B7A: free (in /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so)
==4426==    by 0x59E9615: g_free (gmem.c:190)
==4426==    by 0xA81EA3D: store_info_free (em-folder-tree-model.c:250)
==4426==    by 0x59D326A: g_hash_table_remove_node (ghash.c:204)
==4426==    by 0x59D41F0: g_hash_table_remove_internal (ghash.c:848)
==4426==    by 0xA81D9F6: em_folder_tree_model_remove_folders (em-folder-tree-model.c:881)
==4426==    by 0xA81DDFE: em_folder_tree_model_remove_store (em-folder-tree-model.c:941)
==4426==    by 0xA81E613: account_changed (em-folder-tree-model.c:399)
==4426==    by 0x5979C69: g_cclosure_marshal_VOID__OBJECT (gmarshal.c:636)
==4426==    by 0x596BC2A: g_closure_invoke (gclosure.c:767)
==4426==    by 0x5983424: signal_emit_unlocked_R (gsignal.c:3256)
==4426==    by 0x5984B5F: g_signal_emit_valist (gsignal.c:2988)
==4426==

Comment 1 Milan Crha 2008-07-21 16:09:29 UTC

Created attachment 114926 [details] [review]
proposed evo patch

for evolution;

I guess this should help. Can you test for me, please? (I have a bit unstable evo at the moment because of the db-summary, thus your help will be appreciated. Thanks a lot.)

Comment 2 Akhil Laddha 2008-07-23 04:57:37 UTC

Thanks milan, patch works.

Comment 3 Srinivasa Ragavan 2008-07-27 18:39:07 UTC

Commit it Milan.

Comment 4 Milan Crha 2008-07-28 07:29:26 UTC

Committed to trunk. Committed revision 35850.

Comment 5 Milan Crha 2008-09-18 17:35:40 UTC

*** Bug 541461 has been marked as a duplicate of this bug. ***