GNOME Bugzilla – Bug 543300
[qtdemux] [PATCH] wrong depth in RLE video caps and wrong qt par
Last modified: 2008-07-18 20:04:03 UTC
_parse_trak reads depth from stsd atom using an offset that by that time is already set for reading from tkhd atom, which evidently leads to wrong values.
Created attachment 114673 [details] [review] Read RLE depth from proper location. * Depth in stsd has already been read, take it from there instead of reading again. Also, first read from tkhd, and then from stsd so as not to alter offset for optional later stsd processing.
Created attachment 114675 [details] [review] Revert pixel-aspect-ratio calculation. Upon further reflection, it is better to revert the commit that calculates pixel-aspect-ratio, which introduced the problem. That calculation is otherwise correct according to ISO specs, but not to qt specs (sigh). So better to avoid for now rather than having a FIXME about checking the file type. Attached patch reverts.
OK, let's revert
2008-07-18 Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> * gst/qtdemux/qtdemux.c: (gst_qtdemux_add_stream), (qtdemux_parse_trak): Revert ISO base media spec based pixel-aspect-ratio calculation. Fixes #543300.