After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 542922 - Use playbin2 instead of playbin
Use playbin2 instead of playbin
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 406807
 
 
Reported: 2008-07-14 13:21 UTC by Bastien Nocera
Modified: 2009-05-23 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin2 reimplementation of rb-player-gst.c (21.83 KB, text/plain)
2009-02-15 13:49 UTC, Jonathan Matthew 		  Details
attempt at getting vis working (24.33 KB, patch)
2009-03-20 12:23 UTC, Jonathan Matthew 		none Details | Review
updated playbin2 backend (23.14 KB, text/plain)
2009-04-07 12:27 UTC, Jonathan Matthew 		  Details
updated (60.83 KB, patch)
2009-04-30 01:50 UTC, Jonathan Matthew 		committed Details | Review

Description Bastien Nocera 2008-07-14 13:21:45 UTC 
Rhythmbox should use playbin2, instead of the original playbin:
- builtin support for gapless playback (see about-to-finish signal)
- better streaming support
- allow to disable video completely, and only support viz if required
Comment 1 Jonathan Matthew 2009-02-15 13:49:17 UTC 
Created attachment 128772 [details]
playbin2 reimplementation of rb-player-gst.c

This doesn't include any of the tee/filter stuff, the cdda hacks are missing, and visualization doesn't work at all, but playback works pretty well.
Comment 2 Jonathan Matthew 2009-03-20 12:23:00 UTC 
Created attachment 131025 [details] [review]
attempt at getting vis working

playbin2 allows vis to be enabled and disabled while running, so we don't need the fake visualizer hack any more.  It's a bit shaky at present, but it does work properly sometimes.
Comment 3 Jonathan Matthew 2009-03-26 07:27:08 UTC 
Vis seems to work reliably after some recent playbin2 updates.
Comment 4 Jonathan Matthew 2009-04-07 12:27:51 UTC 
Created attachment 132264 [details]
updated playbin2 backend

gapless playback now works.  everything else seems OK too.
Comment 5 Jonathan Matthew 2009-04-30 01:50:46 UTC 
Created attachment 133624 [details] [review]
updated

update for recent changes.  filter/tee stuff is in there now, haven't tested it.
Comment 6 Jonathan Matthew 2009-05-23 11:41:54 UTC 
I've updated a few things and committed this as 11b1567a6462bfb333a227d8bb571f3777e0144f.