After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 542506 - gog_plot_type_service_finalize leaks strings in the ::paths list
gog_plot_type_service_finalize leaks strings in the ::paths list
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-07-11 10:50 UTC by Jody Goldberg
Modified: 2008-07-13 08:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
frees paths (438 bytes, patch)
2008-07-11 11:58 UTC, Jean Bréfort 		accepted-commit_now Details | Review
a more consistent fix (2.44 KB, patch)
2008-07-13 08:43 UTC, Jean Bréfort 		committed Details | Review

Description Jody Goldberg 2008-07-11 10:50:53 UTC 
jean: I'm fairly sure we want to free each element of the list.  Could you double check ?

There is also some odd looking code in there from the dawn of time that walks the lists but does nothing ???  The life cycle doesn't look right.  Are we properly removing the family when the plugin is deactivated ?
Comment 1 Jean Bréfort 2008-07-11 11:58:28 UTC 
Created attachment 114384 [details] [review]
frees paths

May be not the whole story
Comment 2 Jody Goldberg 2008-07-13 02:58:05 UTC 
At a minimum let's get that in.  I don't see an obvious solution to the rest of it.  Let's ignore it pending the plugin reworking.
Comment 3 Jean Bréfort 2008-07-13 08:43:22 UTC 
Created attachment 114472 [details] [review]
a more consistent fix

Looks like things are always freed.
Comment 4 Jean Bréfort 2008-07-13 08:49:54 UTC 
Both branches.