After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 542296 - gnome_sound needs to handle pa hangs more gracefully
gnome_sound needs to handle pa hangs more gracefully
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: libgnome maintainer
libgnome maintainer
Depends on:
Blocks:
 
 
Reported: 2008-07-10 02:16 UTC by Jeffrey Stedfast
Modified: 2008-07-22 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libgnome-esd-connection.patch (2.69 KB, patch)
2008-07-10 02:17 UTC, Jeffrey Stedfast 		none Details | Review

Description Jeffrey Stedfast 2008-07-10 02:16:02 UTC 
PulseAudio hangs more often than a deadbeat surf bum on holiday so I often get hangs in my gnome apps (like the splash screen during login, logging out of my desktop, using Pidgin, the list goes on...)

Clearly gnome-sound.c needs to deal more gracefully with this... so, here's an attempt at fixing it.
Comment 1 Jeffrey Stedfast 2008-07-10 02:17:10 UTC 
Created attachment 114279 [details] [review]
libgnome-esd-connection.patch
Comment 2 Jeffrey Stedfast 2008-07-15 16:49:26 UTC 
fixed in svn
Comment 3 Morten Welinder 2008-07-17 01:04:17 UTC 
That needs to handle EAGAIN and well as EINTR.

http://bama.ua.edu/cgi-bin/man-cgi?poll+2
Comment 4 Jeffrey Stedfast 2008-07-17 02:13:08 UTC 
Morten: hmmm, yea, you are probably right. the poll() loop should probably also check for EAGAIN.

(when I first read your comment I assumed you meant the write() loop, but EAGAIN there would be handled by the drop back to the poll() loop)
Comment 5 Jeffrey Stedfast 2008-07-18 17:19:47 UTC 
I've added a check for EAGAIN to svn
Comment 6 Kjartan Maraas 2008-07-22 12:28:39 UTC 
Closing this as fixed again.