Created attachment 114225 [details] [review]
Added Solaris USCSI

Removed AM_PROG_CC_STDC because I get "AM_PROG_CC_STDC 's logic has now been merged into Autoconf's AC_PROG_CC macro, therefore you should use the latter instead." from automake doc.

(In reply to comment #1)
> Created an attachment (id=114225) [edit]
> Added Solaris USCSI
> 
> Removed AM_PROG_CC_STDC because I get "AM_PROG_CC_STDC 's logic has now been
> merged into Autoconf's AC_PROG_CC macro, therefore you should use the latter
> instead." from automake doc.
> 
The patch is for configure.in is to check uscsi structure on Solaris.

Created attachment 114226 [details] [review]
Added a new source file for USCSI

Created attachment 114227 [details] [review]
USCSI backend source file

uscsi(7I) is compliant to ANSI Small Computer System Interface-2 (SCSI-2).

So it's the first step to make Brasero work on Solaris (I have successfully write a ISO file to a DVD medium). I will continue fixing the bugs.

I committed your patches to trunk.
Thanks for your work.

Should I close it now or do you want to keep this bug open so as to track all issues?

2008-07-10  Philippe Rouquier  <algernon@localhost.localdomain>

	Fix for #542136 – Brasero on OpenSolaris
	Patch by Lin Ma

	* src/scsi-uscsi.c (brasero_scsi_command_issue_sync),
	(brasero_scsi_command_new), (brasero_scsi_command_free),
	(brasero_device_handle_open), (brasero_device_handle_close):

2008-07-10  Philippe Rouquier  <algernon@localhost.localdomain>

	Fix for #542136 – Brasero on OpenSolaris
	Patch by Lin Ma

	* src/Makefile.am:

2008-07-10  Philippe Rouquier  <algernon@localhost.localdomain>

	Fix for #542136 – Brasero on OpenSolaris
	Patch by Lin Ma

	* configure.in:

*** Bug 507141 has been marked as a duplicate of this bug. ***

(In reply to comment #6)
> I committed your patches to trunk.
Thanks Philippe.

> Should I close it now or do you want to keep this bug open so as to track all
> issues?
No, we can keep it open to track Solaris specific issues.

Note that I think the minor change from bug #507141, where I suggest that the following change be made should go upstream.  This just adds "static" to the definition of "brasero_utils_is_gid_in_groups".  Sun Studio 11 compiler doesn't like it when static functions use non-static inline functions, so adding this static fixes this issue.  As Lin mentions in bug #507141, this is no longer an issue in Sun Studio 12, but it would still be nice to fix this bug so Solaris users with the older compiler (e.g. Solaris 10 users) can still build the code.
Here is the change I am speaking of:

--- brasero-0.7.0/src/brasero-utils.c-orig      2008-01-03 16:57:54.018579000 -0
600
+++ brasero-0.7.0/src/brasero-utils.c   2008-01-03 16:58:37.285554000 -0600
@@ -98,7 +98,7 @@ brasero_utils_init (void)
        g_atexit (brasero_utils_free);
 }
 
-inline gboolean
+static inline gboolean
 brasero_utils_is_gid_in_groups (gid_t gid)
 {
        gid_t *group;

I committed an even simpler fix Brian. The offending function isn't used any more in brasero so I removed it =), which should help.

Created attachment 114717 [details] [review]
some fixes.

ChangeLog is updated. Please review it.

Thanks. I committed your patch. I won't go over the details, I sent you a mail.

Hi Philippe, I have successfully integrated 0.8.2 into Solaris. Thanks for your help. Currently I don't have any further Solaris specific fixes, so I'd like close this bug.

Excellent news. I'm glad to hear that.
How did you solve the privilege problem you mentioned?

(In reply to comment #14)
> Excellent news. I'm glad to hear that.
> How did you solve the privilege problem you mentioned?
> 

Sorry to reply so late.
To use gksu to acquire root privilege due to some backends e.g. growisofs. I should narrow down the acquired privileges in future. There is one issue that if run brasero by root will failed to connect to the user's session bus, so it will fail to get available volumes from gio, so eject will fail. I'm not sure where is the reason. But it looks a Solaris specific bug of dbus. The reason is gksu "dbus-monitor --session" works on Linux, but it will fail on Solaris.