GNOME Bugzilla – Bug 541438
Preview of chat themes
Last modified: 2011-05-03 14:37:47 UTC
In Empathy's Preferences window, in the Themes tab, one can choose a Chat Theme. It would be handy to have a preview of the different themes available in that window so that one does not have to find a nice theme by trial and error.
That's a good idea. Theme support in empathy will be changed in the future to support webkit/adium themes. A fix for this bug could be done in the same time.
Still an issue in 2.27.x
*** Bug 615432 has been marked as a duplicate of this bug. ***
I've started implementation here: http://cgit.collabora.co.uk/git/user/xclaesse/empathy.git/log/?h=preview It already works pretty well, still have some issues: 1) I can't create fake TpAccount so it prints lots of warnings 2) The example conversation is hardcoded, would be great to get in from an xml file or something. 3) When switching to an adium theme, the EmpathyChatView is destroyed/created 2 times.
1) is not easy to fix and is also needed for showing logs archives of an account we removed. empathy_message_from_tpl_log_event() has a FIXME about this too. 2) I would like to use tp-logger, but I need to be able to set a custom location to a TplLogManager for reading its logs. Like tpl_log_manager_new(const gchar *path); which does not return the main singleton. This also block on 1) since I'm not able atm to create an EmpathyMessage from a TplEntry if the account does not exist. 3) is now fixed Since 1 and 2 and complex issues, and we don't even know how to fix them properly, I would like to not block this branch on that. Is that OK? Reviews are welcome.
Created attachment 187114 [details] demo screenshot Mandatory screenshow... WOW
Created attachment 187124 [details] [review] Preferences: Show chat theme preview
Review of attachment 187124 [details] [review]: Please include the bug number in the commit msg. The empathy-theme-manager.c seems be separated from the rest of the branch. Would be better to record it as a separated commit. 1) sounds like a merge blocker to me. I'd rather not merge a patch introducing loads of criticals. ::: src/empathy-preferences.c @@ +691,3 @@ + + /* FIXME: It is ugly to add a fake conversation like that. +static void s/create/request? @@ +695,3 @@ + juliet = g_object_new (EMPATHY_TYPE_CONTACT, + "id", "juliet", + EmpathyPreferences *preferences) Add a translation comment explaining why we are asking them to translate names. :) @@ +703,3 @@ + "is-user", TRUE, + NULL); + EmpathyContact *romeo; Same here, a translator comment telling them to look for an official translation of this text would be cool.
Comments fixed, branch merged. Thanks \o/ commit 74c8015453317b0084bdac8a22e6974e2af0865d