After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541420 - [PATCH] Please add two new settings to the gconf schema files
[PATCH] Please add two new settings to the gconf schema files
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgnome maintainer
libgnome maintainer
Depends on:
Blocks: 539786
 
 
Reported: 2008-07-03 17:51 UTC by Lennart Poettering
Modified: 2008-07-22 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
broken patch from Lennart ;) (1.71 KB, patch)
2008-07-15 14:51 UTC, Bastien Nocera 		needs-work Details | Review
fixed patch (1.72 KB, patch)
2008-07-15 16:18 UTC, Lennart Poettering 		accepted-commit_now Details | Review

Description Lennart Poettering 2008-07-03 17:51:08 UTC 
Please describe the problem:
The patch in ticket 539786 introduces two new gconf settings for sound related stuff. Since the other sound related settings are also stored in libgnome's schema files I prepared a patch for libgnome for the new gcon options, too.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Lennart Poettering 2008-07-03 17:52:14 UTC 
Hmm, my browser (rawhide...) doesn't allow me to upload the patch to bz. Here's a link to the patch:

http://0pointer.de/public/0001-gconf-schema-data-for-new-sound-event-options.patch

Please merge.
Comment 2 Kjartan Maraas 2008-07-06 17:23:52 UTC 
Somehow I can't download the patch there. Are you sure you can't upload the patch? I'm also using rawhide and have not had problems with that myself.
Comment 3 Lennart Poettering 2008-07-14 21:19:40 UTC 
Hmm, the download works fine here. Could you please try again? If it still doesn't work, I will update to newest rawhide and check if that helps and I can upload the patch.
Comment 4 Bastien Nocera 2008-07-15 14:51:15 UTC 
Created attachment 114599 [details] [review]
broken patch from Lennart ;)
Comment 5 Bastien Nocera 2008-07-15 14:52:04 UTC 
Comment on attachment 114599 [details] [review]
broken patch from Lennart ;)

<snip>
>+      <key>/schemas/desktop/gnome/sound/theme_name</key>
>+      <applyto>/desktop/gnome/sound/theme_name</applyto>
<snip>
>+      <key>/schemas/desktop/gnome/sound/input_feedback_sounds</key>
>+      <applyto>/desktop/gnome/sound/theme_name</applyto>
Notice the applyto is broken.
Comment 6 Lennart Poettering 2008-07-15 16:18:22 UTC 
Created attachment 114604 [details] [review]
fixed patch
Comment 7 Lennart Poettering 2008-07-15 16:42:01 UTC 
Ha, this time firefox crashed *after* uploading, not before. Yay!
Comment 8 Bastien Nocera 2008-07-15 18:10:07 UTC 
> -      <default>false</default>
> +      <default>true</default>

Better not change the default before we remove the esd bits from the control-center. Could you revert that bit, and commit?
Comment 9 Lennart Poettering 2008-07-16 15:34:17 UTC 
Will commit as soon as I have an svn account, which I requested a few hours ago.
Comment 10 Lennart Poettering 2008-07-22 11:02:43 UTC 
Commited in r3756