GNOME Bugzilla – Bug 540529
Remove all GIMP references
Last modified: 2008-07-03 05:47:36 UTC
The GTK+ pkg-config files still say "GIMP Tool Kit" in their Description. About time to call GTK+ "The GTK+ Toolkit" or something...
Or "GNOME Toolkit"
I'm for "GTK+ toolkit". Please go ahead and make that change. It might be worthwhile also grepping over the docs to see if there are more places
Created attachment 113729 [details] [review] Change references Is this okay to commit?
I had no idea this would touch every thing source file... Maybe there should be a section in the docs somewhere explaining the genesis of the name. Other than that, it looks ok to me.
Clear NO from here if I have a voice. What's the purpose of that? This is essentially changing the name of the toolkit, the project, the product.
Made a small note about it in the faq, but maybe someone can write something better.
im in ur gtk, pwning ur gimps
This can't be done without discussion. Reopening. See my earlier comment.
Sorry mitch, I actually committed before I saw your comment.
For what it's worth I like the name "Gtk ToolKit" slightly better than "Gimp ToolKit", but it's not a big deal. Recursive names are cute.
It's about not expanding the acronym, not changing the project name. We did the same to GNOME and GUADEC. You don't write "GNU Network Object...what was the rest??" in your project files. Same applies here.
Since the string "GIMP Toolkit" doesn't really show up any more when I grep for it, I don't quite buy this reasoning.
Buy it or not, this bug is real: "GIMP Tool Kit" has no place in GTK+'s pkg-config file. I don't care about source file headers.
Curiously, why was this committed before today's meeting?
Behdad, i don't really care about the pkg-config file. What I do care about is that this patch is reverted without discussion, just as it was applied without discussion. First commiting such a change and *then* having the discussion is like hanging first, trial later. Not like that please!
We'll discuss it at todays meeting anyway, I guess.
Unfortunately I probably can't attend the meeting tonight, but I hope that my absence doesn't prevent this patch from being reverted, apart from pkg-config and maybe some other places...
I'll be happy to revert the whole thing and just apply it to the pkg-config files and stuff. I'm just waiting until after the discussion before doing anything, because I don't want to revert the entire thing and then be told I need to re-apply the whole thing or something. :)
Well, Mitch, it was discussed in this bug. No one thought it's such a big deal needing discussion with the entire team...
GTK+ meeting today, the decision is that I will revert the entire patch and only change the .pc files. Docs and .[ch] files will go back to the way they were. I'll do this later tonight after work. In the .pc files it will say "GTK+ Graphical UI library"
Created attachment 113821 [details] [review] New patch for .pc files The previous patch is reverted. Let me know if this one is okay to commit.
Yes, please commit
2008-07-03 Cody Russell <bratsche@gnome.org> Bug 540529 – Remove all GIMP references * gtk+-2.0.pc.in: * gdk-2.0.pc.in: * gtk+-unix-print-2.0.pc.in: * gtk+-2.0-uninstalled.pc.in: * gdk-2.0-uninstalled.pc.in: Changed GIMP Toolkit to say GTK+ Graphical UI Library in the pkg-config files.