After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539962 - Void function cannot return value with sun cc
Void function cannot return value with sun cc
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Build system
git-master
Other opensolaris
: Normal critical
: ---
Assigned To: Andreas Köhler
Derek Atkins
Depends on:
Blocks: backport
 
 
Reported: 2008-06-24 14:32 UTC by Halton Huo
Modified: 2018-06-29 22:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for bug #539962 (2.00 KB, patch)
2008-06-24 15:04 UTC, Halton Huo 		committed Details | Review

Description Halton Huo 2008-06-24 14:32:35 UTC 
I'm build gnucash trunk (r17246) with sun cc under Solaris, but get following
fails :

"dialog-transfer.c", line 260: void function cannot return value
Comment 1 Derek Atkins 2008-06-24 14:44:10 UTC 
It's not returning a value.   gnc_xfer_dialog_update_price() is a function returning void, so return gnc_xfer_dialog_update_price() is perfectly legal.

I highly suggest you use a better compiler, like GCC.
Comment 2 Halton Huo 2008-06-24 15:02:49 UTC 
Like bug #539957, make gnucash buildable with other compiler like sun cc is always good. I already finish the patch, will offer later.
Comment 3 Halton Huo 2008-06-24 15:04:53 UTC 
Created attachment 113335 [details] [review]
patch for bug #539962

return value in void function make no sense. This will cause sun cc build fail.

Please check the patch, if it is okay, can I commit?
Comment 4 Andreas Köhler 2008-08-20 09:41:07 UTC 
Looks reasonable.
I am not sure you have commit access though, so I will do that later.
Comment 5 Halton Huo 2008-08-20 10:57:31 UTC 
(In reply to comment #4)
> Looks reasonable.
> I am not sure you have commit access though, so I will do that later.
> 
I do not have it though, read http://wiki.gnucash.org/wiki/Subversion#SVN_write_access, I need get reputation first. :) Please go ahead to commit it, thanks.
Comment 6 Andreas Köhler 2008-09-17 17:43:58 UTC 
Applied to trunk as r17496 and branches/2.2 as 17545 for inclusion in GnuCash 2.2.7.
Thanks a lot!
Comment 7 John Ralls 2018-06-29 22:06:07 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=539962. Please update any external references or bookmarks.