After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539822 - while importing a photo, F-spot should ask for overwrite or ignore for one or all photos
while importing a photo, F-spot should ask for overwrite or ignore for one or...
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: Import
0.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2008-06-23 20:35 UTC by Pedro Villavicencio
Modified: 2018-07-12 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pedro Villavicencio 2008-06-23 20:35:29 UTC
This bug has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/f-spot/+bug/242418

"Actually, I import photos from my iPhone (Apple).
I use a special directory to stock my iPhone photos and I don't want to delete them from the iPhone. So importing photos with F-spot looks like a synchronisation...

When I try to import my photos, a few of them are already in the directory, so I have a message box from F-spot like :
-----------
Win32 IO returned ERROR_ALREADY_EXISTS. Path /home/cyrille/Photos/iPhone/img_048.jpg
[...]
[ Erreur lors du transfert de fichier ] (french for : File transfer error)
-----------

and then, we can choose :
- retry (fail because the photo is still here...)
- ignore (I must do that for ALL the photos :/ )
- cancel (quit F-spot)

F-spot should REALLY allow us to :
- overwrite / overwrite all
- ignore / ignore all

because when you have for example, 250 photos already imported and you want to reimport them with 20 new photos (all the photos stocked in the device, without choosing which one you must import or not...), it takes a long time..."

Thanks,
Comment 1 Daniel Kahn Gillmor 2008-12-18 01:33:12 UTC
I can confirm that this is happening (though i don't think i have the privileges to change the status out of UNCONFIRMED here).

It is potentially a real problem for two fairly common scenarios:

 * the user who chooses to leave photos on her camera and then tries to import them again (similar to the bug reporter, as well as people i currently support).

 * the user with two cameras (or two memory cards for one camera), who tries to import *different* photos with the same name.

Here's a proposal for how to handle an import of a file with the same name that already exists in the archive:

 * compare the sha1sum of the incoming file with the sha1sum of all matching stored files (see note below for why this is plural).
 * if there is no match, autogenerate a new, non-colliding name for the file (e.g. img_0908.jpg becomes img_0908.1.jpg (or img_0908.2.jpg, etc)), andn store it with that name.
 * if there is a match, provide a simple notice in the import progress view that says that the file has already been imported, and do not import again.

Note that you'll probably want to compare the incoming image with the sha1sums of *all* the images that originally were titled that way.  So an incoming img_0908.jpg would be compared against the already-stored files img_0908.1.jpg, img_0908.2.jpg, etc.  This prevents a single name collision repeatedly imported from turning into a cascade of extra copies.
Comment 2 André Klapper 2018-07-12 00:01:47 UTC
F-Spot has moved to https://github.com/f-spot/f-spot/issues

If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub.

Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.