GNOME Bugzilla – Bug 539786
[PATCH] Please add three new XSETTINGS to the xsettings plugin
Last modified: 2008-07-22 11:12:28 UTC
Please add Net/SoundThemeName, Net/EnableEventSounds, Net/EnableInputFeedbackSounds as new settings to the XSETTINGS that g-s-d manages. I will shortly post an explanation of these settings to the xdg devel. Basically they are intended to be used: 1) to specify the XDG sound theme to be used 2) to enable/disable event sounds globally 3) to disable only input feedback sounds (i.e. button clicks) but leave other event sounds (i.e. "you got mail!") enabled.
Hmm, my epiphany from rawhide refuses to upload patches. Just does nothing, so here's a link to the patch instead of an attachment: http://0pointer.de/public/gsd-canberra.patch
Also see bug 539790.
Oh, and another small comment: The Net/EnableEventSounds settings is hooked up with the already existing gconf setting /desktop/gnome/sound/event_sounds. For the other two I added new gconf keys.
Here's the mail to the XDG ml: http://lists.freedesktop.org/archives/xdg/2008-June/009711.html
You also need to file a libgnome bug to add schema entries for these new gconf keys.
(In reply to comment #5) > You also need to file a libgnome bug to add schema entries for these new gconf > keys. It would probably make sense to move those schema entries from libgnome to g-s-d, wouldn't it?
Patch looks ok to me, although I'm wondering if 2) and 3) wouldn't make more sense as a single key. Since it looks like the cake is mostly gone already, though, go ahead and commit. (In reply to comment #6) > > You also need to file a libgnome bug to add schema entries for these new gconf > > keys. > > It would probably make sense to move those schema entries from libgnome to > g-s-d, wouldn't it? Sooner or later, yes. Now, probably not (unless you volunteer, I guess...).
The patch for the schema files is in bug 541420. Mathias already fixed 539790. There was no opposition to these new xsettings settings on the xdg ml (actually, there was no reply at all...), so I figure most parties are happy with this new patch and would like to see it merged, or at least ambivalent about it.
Please apply.
Commited in r399