After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538144 - Crash/NRE in PulseAnimation
Crash/NRE in PulseAnimation
Status: RESOLVED FIXED
Product: Tasque
Classification: Other
Component: General
unspecified
Other All
: Normal critical
: ---
Assigned To: tasque-maint
tasque-maint
Depends on:
Blocks:
 
 
Reported: 2008-06-13 12:49 UTC by Ankit Jain
Modified: 2008-06-13 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.34 KB, patch)
2008-06-13 12:52 UTC, Ankit Jain 		none Details | Review
Updated patch. (1.47 KB, patch)
2008-06-13 13:29 UTC, Ankit Jain 		committed Details | Review

Description Ankit Jain 2008-06-13 12:49:46 UTC 
Please describe the problem:
Mark a task as complete and before the animation completes, close the
window, PulseAnimation throws a NRE and application crashes.

Steps to reproduce:
1. 
2. 
3. 


Actual results:
Application crashes.

Expected results:
No crash!

Does this happen every time?
Yes

Other information:
Tested with svn r71
Comment 1 Ankit Jain 2008-06-13 12:52:06 UTC 
Created attachment 112675 [details] [review]
Proposed patch
Comment 2 Sandy Armstrong 2008-06-13 13:19:26 UTC 
Looks great, works perfectly...minor nitpick: instead of deleting the comment that starts with "Emit this signal", could you move it into the else block?

After that, feel free to commit, if you have access.  Otherwise, let me know and I'll commit.

Thanks!
Comment 3 Ankit Jain 2008-06-13 13:29:40 UTC 
Created attachment 112679 [details] [review]
Updated patch.
Comment 4 Ankit Jain 2008-06-13 13:30:13 UTC 
Oops, fixed.
Comment 5 Sandy Armstrong 2008-06-13 14:06:24 UTC 
Perfect.  Please commit.
Comment 6 Ankit Jain 2008-06-13 14:11:27 UTC 
Forgot to mention, I don't have commit rights :/
Comment 7 Sandy Armstrong 2008-06-13 14:27:07 UTC 
Committed in r72.  By the way, that last patch was in some sort of git format...please make sure to always generate patches using svn diff.  I fixed this one for free!  :-P