GNOME Bugzilla – Bug 537021
[cdio] does not extract album title from CD-TEXT
Last modified: 2008-06-09 20:06:16 UTC
Please describe the problem: In the current implementation the cdio library could know about the album name, the album artist and the genre using cdtext but the cdiocddasrc does not use it. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information: Beside there is no Tag for the album-artist but cdio could provide it. Maybe use the PERFORMER tag for that?
Created attachment 112290 [details] [review] reads the album and genre tag of the cd text using cdio and propagate it Beside there is no Tag for the album-artist but cdio could provide it. Maybe use the PERFORMER tag for that?
I'm a bit confused - how does this fit in with already-existing gst_cdio_get_cdtext()? The current implementation assumes the cdtext metadata as it is retrieved is per track, not per album metadata (which is also what I found when I tested it) - do you have evidence that this is wrong?
Also using GST_TAG_ARTIST maybe makes sense nonetheless... at least for single-artist albums it will get the correct value.
@ Tim Phillip Müller: The problem is that cdtext also supports a general Artist and Title for the CD but the API of cdio does not exactly allow you to give it. Because of this they have the work-around that you get these values, when you do cdio_get_cdtext for track 0. Then you get again title and artist, but for the album. The point is that gst_cdio_get_cdtext always modifies the tags ARTIST and TITLE. This is meant to be like this because gst-cdio always propagates the metadata of the current text. This new method I created uses the same cdio_get_cdtext call (for track 0) but writes the values to other tags (to GENRE and ALBUM). @ Sebastian Dröge: GST_TAG_ARTIST is already used for the Metadata of each track. IMHO (as I don't exaclty understand the difference between ARTIST and PERFORMER in Gstreamer context) the Artist of an Album is the Main-Artist that is responsible for the whole recording and then you have the PERFORMER(s) for a single Track. That is even better usable for Samplers. The problem about this is, that it kind of brakes the API as cdio at the moment sends the artist as the artist of each track.
Ah, right, I didn't notice the 0, sorry :) Committed: 2008-06-09 Tim-Philipp Müller <tim.muller at collabora co uk> Patch by: Benjamin Kampmann <benjamin at fluendo dot com> * ext/cdio/gstcdio.c: (gst_cdio_get_cdtext), (gst_cdio_add_cdtext_album_tags): * ext/cdio/gstcdio.h: * ext/cdio/gstcdiocddasrc.c: (gst_cdio_cdda_src_open): Also extract album title and album genre from CD-TEXT if available (#537021). We should probably add a GST_TAG_ALBUM_ARTIST at some point; will have to wait for the next round of releases though (there's already a bug somewhere for that).