Created attachment 112047 [details] [review]
Patch to implement the feature

Neat! at a quick glance the code looks good to me (modulo the fact that I'd prefer it to use the gnome codestyle of tabs for indentation).

Before merging it however, I'd like to hear some opinions since - given that baobab is installed by default and nautilus extensions can not be enabled/disabled - this means adding a menu item on every folder icon and I recall there were some complaints about the context menu beeing too cluttered.

Also, shouldn't it be "analyze" instead of "analyse"?

Thomas,

thank you very much for the patch. I will run it lately tomorrow as I am out of home now. As Paolo said, we should discuss the "context menu cluttering" issue before merging.

Fabio

Created attachment 112068 [details] [review]
Updated patch with corrected strings

Here's an updated patch with correct captialisation and en_US strings rather than en_GB.

I agree about not wanting to add more clutter to the context menus. A simple solution to this might be to add a gconf key set by the preference window in Baobab. The nautilus extension would not create the menu item unless the gconf key is enabled.

With regards to indentation, I'm not aware of any official GNOME coding style, but feel free to run indent or uncrustify over my patches!

wouldn't a button in the nautilus properties dialog be good option too?

*** Bug 439900 has been marked as a duplicate of this bug. ***

I discussed a bit with the design team and it was decided that putting baobab in every folder context menu is too prominent