After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536317 - [v4l2src] Doesn't compile with latest git kernel
[v4l2src] Doesn't compile with latest git kernel
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-02 20:36 UTC by Bastien Nocera
Modified: 2008-07-18 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update for new kernel (1.67 KB, patch)
2008-06-02 20:37 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-06-02 20:36:21 UTC
From http://koji.fedoraproject.org/koji/getfile?taskID=640384&name=build.log
---8<---
v4l2_calls.c:268: error: 'V4L2_CID_HCENTER' undeclared (first use in this function)
v4l2_calls.c:268: error: (Each undeclared identifier is reported only once
v4l2_calls.c:268: error: for each function it appears in.)
v4l2_calls.c:269: error: 'V4L2_CID_VCENTER' undeclared (first use in this function)
---8<---

Those 2 have been deprecated. Patch below should fix compilation, and allow use of the new ioctls instead of the old ones. The old ioctls aren't used by any drivers anymore, so we should use them in gstv4l2vidorient.c, but still handle both the old and the new versions in the switch statement in v4l2_calls.c.

See discussion at:
http://thread.gmane.org/gmane.linux.redhat.fedora.devel/86198
and:
http://lkml.org/lkml/2008/6/2/310
Comment 1 Bastien Nocera 2008-06-02 20:37:04 UTC
Created attachment 111995 [details] [review]
Update for new kernel

Absolutely untested.
Comment 2 Bastien Nocera 2008-06-03 12:22:44 UTC
Builds fine on all arches Fedora supports:
http://koji.fedoraproject.org/koji/buildinfo?buildID=51424
Comment 3 Sebastian Dröge (slomo) 2008-06-09 08:43:05 UTC
Committed (with added #ifdefs for the new ioctl names in the switch)

2008-06-09  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Bastien Nocera <hadess at hadess dot net>

        * sys/v4l2/gstv4l2vidorient.c:
        * sys/v4l2/v4l2_calls.c: (gst_v4l2_fill_lists):
        Fix compilation with newer GIT kernels that deprecated
        V4L2_CID_HCENTER and V4L2_CID_VCENTER. Fixes bug #536317.
Comment 4 Levente Farkas 2008-07-01 11:48:26 UTC
but this is not working if V4L2_CID_PAN_RESET and V4L2_CID_TILT_RESET not defined anywhere (which is the case for all old kernel)?
+      case V4L2_CID_PAN_RESET:
+      case V4L2_CID_TILT_RESET:
Comment 5 Bastien Nocera 2008-07-01 13:05:24 UTC
(In reply to comment #4)
> but this is not working if V4L2_CID_PAN_RESET and V4L2_CID_TILT_RESET not
> defined anywhere (which is the case for all old kernel)?
> +      case V4L2_CID_PAN_RESET:
> +      case V4L2_CID_TILT_RESET:

It was probably never working in those cases actually. File a new bug if that's a problem.