After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 535360 - Google search extension for Deskbar
Google search extension for Deskbar
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: Modules
2.22.x
Other All
: Normal enhancement
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-05-28 22:05 UTC by Moo
Modified: 2008-08-01 08:20 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Proposed Google search handler (6.86 KB, text/plain)
2008-07-24 21:11 UTC, Helton Doria
Details
New code using the new get_locale_lang function (8.14 KB, text/plain)
2008-07-31 22:49 UTC, Helton Doria
Details

Description Moo 2008-05-28 22:05:52 UTC
Deskbar comes with a Yahoo search extension.

I propose to add a Google search extension to Deskbar.
Many people prefer Google over Yahoo.
Comment 1 Sebastian Pölsterl 2008-05-30 10:35:31 UTC
Marking as gnome-love.

Information on retrieving Google Search results is available at http://code.google.com/apis/ajaxsearch/documentation/#fonje
Comment 2 Helton Doria 2008-07-24 21:11:11 UTC
Created attachment 115202 [details]
Proposed Google search handler

Hi, 

This is my proposal of Google Search module for the deskbar-applet. I created the code based on the others modules found in the svn tree and based on the information present in the link that you provided. I did some local tests and everything worked fine. If something isn't correct or need to be improved, let me know.
Comment 3 Sebastian Pölsterl 2008-07-25 08:38:56 UTC
Excellent work, works fine.

wikipedia-suggest already has way to guess the user's prefered language. This is useful for both yahoo and google search. I'm going to extract that piece of code from wikipedia-suggest that you can use that in the google module, too.
Comment 4 Helton Doria 2008-07-25 19:54:22 UTC
Thanks :)

I'll be waiting.
Comment 5 Sebastian Pölsterl 2008-07-29 20:16:03 UTC
deskbar.core.Utils contains a get_locale_lang function now. Both wikipedia-suggest and yahoo make use of it. Keep in mind that Chinese Simplified/Traditional are special cases.
Comment 6 Helton Doria 2008-07-31 22:49:25 UTC
Created attachment 115646 [details]
New code using the new get_locale_lang function

Here is the new code making use of the new function get_locale_lang. I tested here and everything worked fine. Let me know if it shows any problem.
Comment 7 Sebastian Pölsterl 2008-08-01 08:20:09 UTC
2008-08-01  Sebastian Pölsterl  <sebp@cvs.gnome.org>

    * deskbar/handlers/googlesearch.py:
    * deskbar/handlers/Makefile.am:
    * po/POTFILES.in:
    Added Google search module. Written by
    Helton Doria <helton dot doria at gmail dot com>
    Requires simplejson Python module. Fixes bug #535360