GNOME Bugzilla – Bug 534565
HTML bookmarks containing %s are not exported correctly
Last modified: 2012-10-02 09:06:12 UTC
When you export a bookmark containing %s to HTML, remove the bookmark and import it again, the link changes. http://www.google.com/search?q=%s becomes http://www.google.com This might be usefull when opening the exported HTML-file in a browser, because you have links which actually work, when you click them. On the other hand it makes a usefull backup using HTML-export impossible. Either it should be changed to use the correct url, since backup is more commonly used than viewing the exported file in a browser. Or the HTML-file could contain the correct link as a <!-- --> comment, while the anchor-tag still uses the changed link, but that would require changes in the importer, too.
Created attachment 211223 [details] [review] Prioritizes smart link URIs over regular ones
Review of attachment 211223 [details] [review]: This looks good to me, thank you for the patch!
Hey William, I asked chpe about this and he suggested the reason this was done in the past was because Firefox would not accept bookmarks exported with the '%s' in it. Could you verify this still works with this patch?
Sorry about the late response, I thought I was added to the bug report's CC list but apparently not. I just tested an export of a smart bookmark with a bookmarks.html file containing the entry: <dt><a href="http://www.google.com/search?q=%s">Google Bug Test %s</a></dt> I then imported it into a new profile under Firefox 12. The bookmark imported successfully into Firefox and worked properly. However, it doesn't resolve into a smart link, but functions as a normal link instead searching for the term "%s" via Google.
Comment on attachment 211223 [details] [review] Prioritizes smart link URIs over regular ones Pushed to master, thank you William!
Closing.
*** Bug 685116 has been marked as a duplicate of this bug. ***