Bug 534132 – opt_rgw hang

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 534132 - opt_rgw hang


Summary:	opt_rgw hang


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	Analytics
Version:	git master
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Morten Welinder
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-05-21 03:13 UTC by sum1
Modified:	2008-08-29 12:55 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix opt_rgw documentation. (1.57 KB, patch) 2008-08-24 12:33 UTC, Hal Ashburner	accepted-commit_now	Details \| Review

Description sum1 2008-05-21 03:13:50 UTC

Version: r16592
OS: Ubuntu Hardy

Steps to reproduce:
- Enter '=opt_rgw(0,35/45,-1,2/5/2008,F182,2/5/2008,K36)' (no quotes) into A1

Backtrace:

Program received signal SIGINT, Interrupt.

+ Trace 198272

Thread 3061267040 (LWP 8272)

#0 opt_bs1
at options.c line 199
#1 opt_rgw1
at options.c line 996
#2 opt_rgw
at options.c line 1039
#3 function_call_with_exprs
at func.c line 1247
#4 gnm_expr_eval
at expr.c line 1321
#5 gnm_expr_top_eval
at expr.c line 2839
#6 gnm_cell_eval_content
at dependent.c line 1450
#7 gnm_rendered_value_new
at rendered-value.c line 210
#8 gnm_cell_render_value
at cell.c line 469
#9 row_calc_spans
at cellspan.c line 411
#10 sheet_range_bounding_box
at sheet.c line 2250
#11 scg_redraw_range
at sheet-control-gui.c line 147
#12 sc_redraw_range
at sheet-control.c line 89
#13 sheet_redraw_partial_row
at sheet.c line 1010
#14 sheet_cell_calc_span
at sheet.c line 1102
#15 sheet_cell_set_text
#16 cmd_set_text_redo
at commands.c line 851
#17 command_push_undo
at commands.c line 742
#18 cmd_set_text
#19 wbcg_edit_finish
at wbc-gtk-edit.c line 222
#20 cb_gee_key_press_event
at gnumeric-expr-entry.c line 507

Comment 1 Hal Ashburner 2008-06-03 17:06:44 UTC

adding self to cc list

Comment 2 Morten Welinder 2008-06-18 23:34:11 UTC

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Comment 3 Hal Ashburner 2008-08-24 12:00:28 UTC

Grr, Bugzilla. Never got notification of Morten's update despite clearly having added mysyelf to the cc list.
My svn up changes the changelog, doesn't seem to fix the problem, which is getting the first arg of opt_rgw as a float when it should be string.
Will attach patch.

Comment 4 Hal Ashburner 2008-08-24 12:33:12 UTC

Created attachment 117295 [details] [review]
Fix opt_rgw documentation.

Roll Geske Whaley is a Call option valuation routine. There is no call/put flag. It should never have been there in the first place. The author of this code was a goose when he wrote it and probably still is. ;) 
Patch fixes the documentation, names in the formula guru etc.

Comment 5 J.H.M. Dassen (Ray) 2008-08-28 20:20:20 UTC

(In reply to comment #2)
> This problem has been fixed in the development version.

For reference: http://svn.gnome.org/viewvc/gnumeric?view=revision&revision=16633
and it is included as of 1.9.1.

AFAICT, this just leaves the updated documentation (comment #4) to be added
before this report can be closed.

Comment 6 Jody Goldberg 2008-08-29 12:46:12 UTC

Comment on attachment 117295 [details] [review]
Fix opt_rgw documentation.

This clearly matches the code better than the old version.   Please commit.

Comment 7 J.H.M. Dassen (Ray) 2008-08-29 12:55:20 UTC

As noted in comment #2, comment #5, the crash is fixed as of 1.9.1

I've now committed the improved description:
	http://svn.gnome.org/viewvc/gnumeric?view=revision&revision=16755
and with that, I'm now closing this report.