Bug 533515 – r.qpois() hang

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 533515 - r.qpois() hang


Summary:	r.qpois() hang


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	Analytics
Version:	git master
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Morten Welinder
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-05-17 06:27 UTC by sum1
Modified:	2008-05-17 22:20 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
check lambda value and fixes the issue (554 bytes, patch) 2008-05-17 15:00 UTC, Jean Bréfort	none	Details \| Review
removed an extra line accidently left in the patch (500 bytes, patch) 2008-05-17 15:52 UTC, Jean Bréfort	none	Details \| Review

Description sum1 2008-05-17 06:27:03 UTC

Version: r16575
OS: Ubuntu Hardy

Steps to reproduce:
- Enter '=r.qpois(-1,-1.5,-1.0%,-1.0%)' (no quotes) into A1

Backtrace:

+ Trace 197931

#0 ppois
at mathfunc.c line 830
#1 ppois1
at mathfunc.c line 6056
#2 discpfuncinverter
at mathfunc.c line 6009
#3 qpois
at mathfunc.c line 6070
#4 gnumeric_r_qpois
at functions.c line 705
#5 function_call_with_exprs
at func.c line 1247
#6 gnm_expr_eval
at expr.c line 1319
#7 gnm_expr_top_eval
at expr.c line 2837
#8 gnm_cell_eval_content
at dependent.c line 1450
#9 gnm_rendered_value_new
at rendered-value.c line 210
#10 gnm_cell_render_value
at cell.c line 469
#11 row_calc_spans
at cellspan.c line 411
#12 sheet_range_bounding_box
at sheet.c line 2250
#13 scg_redraw_range
at sheet-control-gui.c line 147
#14 sc_redraw_range
at sheet-control.c line 89
#15 sheet_redraw_partial_row
at sheet.c line 1010
#16 sheet_cell_calc_span
at sheet.c line 1102
#17 sheet_cell_set_text
#18 cmd_set_text_redo
at commands.c line 851
#19 command_push_undo
at commands.c line 742
#20 cmd_set_text
#21 wbcg_edit_finish
at wbc-gtk-edit.c line 222
#22 cb_gee_key_press_event
at gnumeric-expr-entry.c line 507

Comment 1 Jean Bréfort 2008-05-17 14:57:51 UTC

when lambda is negative or nul, the function must return an error. It works fine when logp is FALSE or if the first argument is positive, but enters an infinite loop otherwise.
The easy solution is to check that lambda is positive in gnumeric_r_qpois.

Comment 2 Jean Bréfort 2008-05-17 15:00:58 UTC

Created attachment 111049 [details] [review]
check lambda value and fixes the issue

Comment 3 Jean Bréfort 2008-05-17 15:52:00 UTC

Created attachment 111053 [details] [review]
removed an extra line accidently left in the patch

Comment 4 Morten Welinder 2008-05-17 22:07:00 UTC

I have this under control.  We need to fix this in mathfunc.c and there
are a few other problems.

Comment 5 Morten Welinder 2008-05-17 22:20:13 UTC

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.