Bug 533247 – Crash in link_single_dep()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 533247 - Crash in link_single_dep()


Summary:	Crash in link_single_dep()


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	Analytics
Version:	git master
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Morten Welinder
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-05-15 08:45 UTC by sum1
Modified:	2008-05-17 05:37 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
proposed patch (929 bytes, patch) 2008-05-15 09:31 UTC, Jean Bréfort	committed	Details \| Review

Description sum1 2008-05-15 08:45:42 UTC

Version: r16561
OS: Ubuntu Hardy

Steps to reproduce:
- Enter '=index(imcsch())' (no quotes) into A1


Backtrace:

Program received signal SIGSEGV, Segmentation fault.

+ Trace 197770

Thread 3062057568 (LWP 10135)

#0 link_single_dep
at dependent.c line 860
#1 dependent_add_dynamic_dep
at dependent.c line 1279
#2 gnm_expr_eval
at expr.c line 1324
#3 gnm_expr_top_eval
at expr.c line 2837
#4 gnm_cell_eval_content
at dependent.c line 1450
#5 gnm_rendered_value_new
at rendered-value.c line 210
#6 gnm_cell_render_value
at cell.c line 469
#7 row_calc_spans
at cellspan.c line 411
#8 sheet_range_bounding_box
at sheet.c line 2250
#9 scg_redraw_range
at sheet-control-gui.c line 147
#10 sc_redraw_range
at sheet-control.c line 89
#11 sheet_redraw_partial_row
at sheet.c line 1010
#12 sheet_cell_calc_span
at sheet.c line 1102
#13 sheet_cell_set_text
#14 cmd_set_text_redo
at commands.c line 851
#15 command_push_undo
at commands.c line 742
#16 cmd_set_text
#17 wbcg_edit_finish
at wbc-gtk-edit.c line 222
#18 gnm_pane_key_mode_sheet
at gnm-pane.c line 407
#19 gnm_pane_key_press
at gnm-pane.c line 596

Comment 1 Jean Bréfort 2008-05-15 09:04:13 UTC

Seems that the index functionshould check the value type of its first argument and return an error if it is not a cell range.

Comment 2 Jean Bréfort 2008-05-15 09:31:13 UTC

Created attachment 110945 [details] [review]
proposed patch

Comment 3 Jean Bréfort 2008-05-15 11:29:59 UTC

No more crash with the patch above, but a critical and a value leak:

** (gnumeric:31369): CRITICAL **: go_linear_regression: assertion `n >= 1' failed
Leaking 1 values.
Leaking string [#N/A] with ref_count=1.

Comment 4 Morten Welinder 2008-05-15 13:15:01 UTC

Comment on attachment 110945 [details] [review]
proposed patch

Looks good.  Both branches.

Comment 5 Jean Bréfort 2008-05-17 05:37:04 UTC

This problem has been fixed in our software repository. The fix will go into
the next software release. Thank you for your bug report.