GNOME Bugzilla – Bug 530784
whereAmI info for list items in web content needs to be improved
Last modified: 2009-06-12 15:53:34 UTC
There are many different kinds of lists and list items in web content: form field lists, (un)ordered and definition lists (some of which have embedded object characters in them), lists of links used as navbars, ARIA and Dojo widgets, etc. We need to specifically handle the various types.
Initially I was planning on doing this in time for string announcement period. Mike and I are meeting and in light of our total bug count, we agree that this bug is low priority. Re-targeting to FUTURE.
Created attachment 135280 [details] [review] revision 1 When I looked at this issue, we're doing what is expected for most lists. The problem turned out to be: 1. If the list item has children (paragraphs, sections, etc.), we'd present the children but not the list item. 2. We were not presenting the level of a nested list. This patch address both conditions and does so without introducing new strings (because we present nesting level already as part of structural navigation). So if it's deemed low risk, we could include it for 2.26.3. This patch also includes a new test case and regression test. Will, please review. Thanks!
Created attachment 135281 [details] [review] revision 1 with trailing whitespace removed from regression test Same silly patch. Git complained that I had trailing whitespace in my regression test file. <rolls eyes>
I think this looks fine and say commit to master and gnome-2-26. The regression test change may cause some integration/merge issues when we integrate bug #570658, but it will be isolated to just that test and we can hopefully work it out. Thanks!
Thanks Will. I'm sure we can work out those changes. :-) Patch committed to both master and the gnome-2-26 branch. Closing as FIXED.
The fix for this bug added this change, which has caused the text contents to stop speaking for the Where Am I operation in the To/CC/etc. fields of Thunderbird's mail composition window: - if obj.getRole() != pyatspi.ROLE_ENTRY: - return self._speakTableCell(cell, basicOnly) + if ancestor.getRole() == pyatspi.ROLE_TABLE_CELL: + if obj.getRole() != pyatspi.ROLE_ENTRY: + return self._speakTableCell(ancestor, basicOnly) + else: + return self._speakListItem(ancestor, basicOnly) I'm reopening this bug because this needs to be addressed for gnome-2-26. For whatever is done here to fix this for gnome-2-26, we should also do a similar fix in the new Where Am I code being discussed in bug #584529.
Created attachment 136434 [details] [review] proposed patch
Patch (with the correct indentation) committed to the gnome-2-26 branch. It will be addressed in master by a patch Will is doing to simplify the whereAmI code. Re-closing as FIXED.