GNOME Bugzilla – Bug 530778
self.grid.add(), grid==None
Last modified: 2009-05-02 14:34:23 UTC
Version: 2.22.1.1 What were you doing when the application crashed? i started an easy game, clicked the autofill-button many times while double clicking the fields alternately. suddenly one field was covered with that mouse-num-field, which did not disappeared on clicking another field. as i tried to click one of these buggy buttons, the whole app crashed. Distribution: Ubuntu 8.04 (hardy) Gnome Release: 2.22.1 2008-04-15 (Ubuntu) BugBuddy Version: 2.22.0 System: Linux 2.6.24-16-generic #1 SMP Thu Apr 10 13:23:42 UTC 2008 i686 X Vendor: The X.Org Foundation X Vendor Release: 10400090 Selinux: No Accessibility: Disabled GTK+ Theme: Human Icon Theme: Human Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0 CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0 ----------- .xsession-errors --------------------- (firefox:9577): Gtk-CRITICAL **: gtk_widget_destroy: assertion `GTK_IS_WIDGET (widget)' failed (firefox:9577): Gtk-CRITICAL **: gtk_widget_hide: assertion `GTK_IS_WIDGET (widget)' failed (firefox:9577): Gtk-CRITICAL **: gtk_widget_destroy: assertion `GTK_IS_WIDGET (widget)' failed Traceback (most recent call last):
+ Trace 196543
self.entry_validate(widget)
self.add_value(widget.x,widget.y,val)
self.grid.add(x,y,val,True)
-------------------------------------------------- Traceback (most recent call last):
*** Bug 540142 has been marked as a duplicate of this bug. ***
Another race condition...
*** Bug 540214 has been marked as a duplicate of this bug. ***
*** Bug 541480 has been marked as a duplicate of this bug. ***
*** Bug 542488 has been marked as a duplicate of this bug. ***
*** Bug 550490 has been marked as a duplicate of this bug. ***
*** Bug 552872 has been marked as a duplicate of this bug. ***
*** Bug 553666 has been marked as a duplicate of this bug. ***
*** Bug 553805 has been marked as a duplicate of this bug. ***
*** Bug 554166 has been marked as a duplicate of this bug. ***
*** Bug 554186 has been marked as a duplicate of this bug. ***
*** Bug 556219 has been marked as a duplicate of this bug. ***
*** Bug 557168 has been marked as a duplicate of this bug. ***
*** Bug 558105 has been marked as a duplicate of this bug. ***
*** Bug 562116 has been marked as a duplicate of this bug. ***
*** Bug 574129 has been marked as a duplicate of this bug. ***
*** Bug 574874 has been marked as a duplicate of this bug. ***
*** Bug 576043 has been marked as a duplicate of this bug. ***
Fixed on trunk in r8912: Fix will be in 2.27.1 http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8912 2.26.1 material
*** Bug 561382 has been marked as a duplicate of this bug. ***
Created attachment 131542 [details] [review] clean up the code The patch contains: 1. class NumberSelector's key_press_cb() is deleted, since I find it's called nowhere. NumerSelector never gets the 'key_release_event' (which goes to NumberBox). (/me doesn't understand why) 2. clean up the code to destroy num selector to 'destroy_npicker()'. Make sure there is only one number-selector (just as phomes did). Also Make all kinds of npicker-destroying through destroy_npicker, rather than directly calling NumberSelector's destroy(). 3. When the npicker is shown, pressing any key will kill it. I think this is more intuitive. 4. delete SudokuGameDisplay's add_value_to_ui(). I don't know why there is both an add_value and an add_value_to_ui, which is just a simple wrapper around the former. (I just deleted it; there should be more refactor as to the way sudoku fills numbers but I haven't thought thoroughly). 5. Move the code to display conflict-red-color to new method 'complain_conflicts'. The patch possibly contains immature newbie stuff, thanks for review :)
BTW, the 'number_picker_mode' of class NumberSelector is never set to True, I think. If so, it can be deleted (the several places using it should also be rewritten).
Committed Zhangs cleanup patch: http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8916 Nice. Much more clean now. Will remove dead number_picker_mode code. Thanks again!
*** Bug 577836 has been marked as a duplicate of this bug. ***
patch committed to 2.26 branch. Will be in 2.26.1
*** Bug 581095 has been marked as a duplicate of this bug. ***