After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529991 - 12-hour time not handled properly in world clock
12-hour time not handled properly in world clock
Status: RESOLVED OBSOLETE
Product: gnome-panel
Classification: Other
Component: clock
2.22.x
Other All
: Normal major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 527404 530034 543261 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-25 22:22 UTC by Fran Rogers
Modified: 2020-11-06 20:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Re-refresh the location tiles after signal connection (607 bytes, patch)
2008-05-29 19:21 UTC, Kai Willadsen
none Details | Review

Description Fran Rogers 2008-04-25 22:22:24 UTC
Please describe the problem:
If 12-hour format is selected in the new GNOME world clock applet, the time for each location underneath the map will still display in 24-hour format - however, if the clock is left open, at the top of the minute when the times update they properly display in 12-hour notation until the world clock is closed again.

Steps to reproduce:
1. Make sure "12-hour format" is selected in Clock Preferences, and one or more locations are set
2. Click the clock applet to open the clock pop-up panel, expand Locations if not already expanded
3. Note the times for each location are in 24-hour format
4. Wait until the top of the minute
5. Note that after the times refresh, they are in 12-hour format.
6. Click the clock applet to close it, and again to open it
7. Note the times are once again in 24-hour format.


Actual results:
See above

Expected results:
The world clock should consistently display 12-hour times for each Location when 12-hour format is selected.

Does this happen every time?
Yes

Other information:
Comment 1 Pavel Šefránek 2008-04-26 21:44:07 UTC
*** Bug 530034 has been marked as a duplicate of this bug. ***
Comment 2 Pavel Šefránek 2008-04-26 21:44:39 UTC
*** Bug 527404 has been marked as a duplicate of this bug. ***
Comment 3 Bill Nottingham 2008-05-27 20:03:20 UTC
It's also not honored in the time adjustment dialog (for 12 hour it would need to grow an AM/PM selector, of course.)
Comment 4 Kai Willadsen 2008-05-29 19:21:37 UTC
Created attachment 111759 [details] [review]
Re-refresh the location tiles after signal connection

The time format for the city tiles was being requested during tile creation, which was before the "need-clock-format" signal was connected. I'm not sure whether it's the best fix, but adding a separate call to refresh the city tiles after signal connection fixes the bug for me.

Patch is against 2.22.1.3, but should apply to head.
Comment 5 Kai Willadsen 2008-05-29 19:24:39 UTC
Sorry - to be clear, this fixes the reported problem in city tiles, not in the time adjustment dialog.
Comment 6 Vincent Untz 2008-07-27 23:59:08 UTC
*** Bug 543261 has been marked as a duplicate of this bug. ***
Comment 7 Kai Willadsen 2008-11-28 13:49:05 UTC
Revision 11201 fixed the display part of this bug. The problem with the time adjustment dialog mentioned in comment #3 still stands.
Comment 8 André Klapper 2020-11-06 20:25:22 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports in Bugzilla which have not seen updates for many years.

If you can still reproduce this issue in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/

Thank you for reporting this issue and we are sorry it could not be fixed.