After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529283 - [ofa] Unit test leaks tag string
[ofa] Unit test leaks tag string
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-21 21:36 UTC by Sebastian Dröge (slomo)
Modified: 2008-04-21 21:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ofa-check-leak.diff (1008 bytes, patch)
2008-04-21 21:38 UTC, Sebastian Dröge (slomo)
none Details | Review
ofa-check-leak.diff (1.06 KB, patch)
2008-04-21 21:46 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2008-04-21 21:36:31 UTC
Hi,
the ofa unit test currently leaks the tag strings:

Running suite(s): OFA
==17111== 
==17111== 757 bytes in 1 blocks are definitely lost in loss record 3,928 of 3,980
==17111==    at 0x4022AB8: malloc (vg_replace_malloc.c:207)
==17111==    by 0x42D171C: g_malloc (gmem.c:131)
==17111==    by 0x42E9F08: g_strdup (gstrfuncs.c:92)
==17111==    by 0x409C43A: gst_tag_list_get_string (gsttaglist.c:1378)
==17111==    by 0x804A81E: bus_handler (ofa.c:53)
==17111==    by 0x405F288: gst_bus_source_dispatch (gstbus.c:779)
==17111==    by 0x42C9977: g_main_context_dispatch (gmain.c:2009)
==17111==    by 0x42CCBCD: g_main_context_iterate (gmain.c:2642)
==17111==    by 0x42CCF56: g_main_loop_run (gmain.c:2850)
==17111==    by 0x804A6CD: test_ofa_le_1ch (ofa.c:130)
==17111==    by 0x402FF5F: srunner_run_all (in /home/slomo/projects/gstreamer/head/gstreamer/libs/gst/check/.libs/libgstcheck-0.10.so.0.16.0)
==17111==    by 0x804AB28: main (ofa.c:387)
==17141== 


Attached patch fixes this.
Comment 1 Sebastian Dröge (slomo) 2008-04-21 21:38:05 UTC
Created attachment 109654 [details] [review]
ofa-check-leak.diff
Comment 2 Sebastian Dröge (slomo) 2008-04-21 21:46:54 UTC
Created attachment 109655 [details] [review]
ofa-check-leak.diff

Also don't leak the tag list
Comment 3 Sebastian Dröge (slomo) 2008-04-21 21:53:09 UTC
2008-04-21  Sebastian Dröge  <slomo@circular-chaos.org>

        * tests/check/elements/ofa.c: (bus_handler):
        Don't leak the tags string and tag list. Fixes bug #529283.