GNOME Bugzilla – Bug 528257
File selector and stock string problems
Last modified: 2010-08-29 18:07:29 UTC
A string in the file selector has an extraneous full stop after "UTF-8", and the CD-ROM stock item should be "CD-ROM", rather than "CD-Rom". gtkfilesel.c:3047 "The filename \"%s\" couldn't be converted to UTF-8. (try setting the " "environment variable G_FILENAME_ENCODING): %s" "The filename \"%s\" couldn't be converted to UTF-8 (try setting the " "environment variable G_FILENAME_ENCODING): %s" gtkstock.c:301 "_CD-Rom" "_CD-ROM"
Created attachment 121068 [details] [review] Fix file selector and stock string problems Trivial patch to fix the problem (and another similar one with a "harddisk" stock item string).
Created attachment 143837 [details] [review] Miscellaneous string fixes Here are some more string fixes. Most are capitalisation fixes (e.g. "PID" vs "pid", "ID" vs "id"). The other notable fixes: Printer '%s' is currently off-line. -> Printer '%s' is currently offline. Couldn't allocate memory for paletted data -> Couldn't allocate memory for palette data
Comment on attachment 121068 [details] [review] Fix file selector and stock string problems Could you update the patch and commit the gtkstock part (GtkFileSelection was deprecated and removed)?
Comment on attachment 143837 [details] [review] Miscellaneous string fixes Could you update the patch? gdk-pixbuf is now a separate module
commit 12e83244b10e31daa06e611fa9ddb2692117c75b Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Aug 22 12:24:00 2010 +0100 Bug 528257 — File selector and stock string problems Fix some stock item strings. Helps: bgo#528257 gtk/gtkstock.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Created attachment 168493 [details] [review] Miscellaneous string fixes (updated) I'll open a new bug for the string changes to gdk-pixbuf.
(In reply to comment #6) > I'll open a new bug for the string changes to gdk-pixbuf. Bug #627639.
Review of attachment 168493 [details] [review]: looks good
Comment on attachment 168493 [details] [review] Miscellaneous string fixes (updated) commit 5fa4a05cccc818d60bb773cc51056436e16694af Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Aug 22 15:06:45 2010 +0100 Miscellaneous string fixes Mostly capitalisation fixes. Closes: bgo#528257 gdk/gdk.c | 4 ++-- gtk/gtkbuilderparser.c | 2 +- gtk/gtkmountoperation-stub.c | 2 +- gtk/gtkmountoperation-x11.c | 2 +- gtk/gtkmountoperation.c | 2 +- gtk/gtktextbufferserialize.c | 2 +- modules/printbackends/cups/gtkprintbackendcups.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-)
Do you want either of these patches cherry-picking to gtk-2-22? Note that a string change notification e-mail would have to be sent out.
(In reply to comment #10) > Do you want either of these patches cherry-picking to gtk-2-22? Note that a > string change notification e-mail would have to be sent out. Ping? String freeze is approaching fast.
Sorry, Philip. Yeah a patch for gtk-2-22 would be great
It cherry-picked without conflicts. Pushed to gtk-2-22. I'll send out a notification e-mail for these changes and the ones in bug #628198 shortly. commit 818ef9aaf6d89d964a18ed66b9048c719d698e3f Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Aug 22 15:06:45 2010 +0100 Miscellaneous string fixes Mostly capitalisation fixes. Closes: bgo#528257 gdk/gdk.c | 4 ++-- gtk/gtkbuilderparser.c | 2 +- gtk/gtkmountoperation-stub.c | 2 +- gtk/gtkmountoperation-x11.c | 2 +- gtk/gtkmountoperation.c | 2 +- gtk/gtktextbufferserialize.c | 2 +- modules/printbackends/cups/gtkprintbackendcups.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-)