After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526575 - Missing return type in gtk_ui_manager_get_toplevels documentation
Missing return type in gtk_ui_manager_get_toplevels documentation
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
2.12.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-04-06 20:13 UTC by Matt Kraai
Modified: 2008-08-02 04:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (481 bytes, patch)
2008-04-06 20:13 UTC, Matt Kraai 		accepted-commit_now Details | Review
Updated patch that also says to use g_slist_free to free the result (525 bytes, patch)
2008-07-30 00:22 UTC, Matt Kraai 		committed Details | Review

Description Matt Kraai 2008-04-06 20:13:27 UTC 
Documentation 
Section: The GTKUIManager section of the GTK+ Reference Manual
Returns : a newly-allocated of all toplevel widgets of the requested types.

Correct version:
Returns : a newly-allocated GSList of all toplevel widgets of the requested types.

Other information:
Comment 1 Matt Kraai 2008-04-06 20:13:51 UTC 
Created attachment 108735 [details] [review]
Patch
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2008-04-16 06:34:30 UTC 
Quick fix.

http://live.gnome.org/GtkLove/PatchTriaging spam.
Comment 3 Matthias Clasen 2008-07-29 14:11:37 UTC 
Looks fine to me, although it would be better to give an additional explict hint on how to free the return value. Like: "Free the returned list with g_slist_free()."
Comment 4 Matt Kraai 2008-07-30 00:22:57 UTC 
Created attachment 115532 [details] [review]
Updated patch that also says to use g_slist_free to free the result

The attached patch adds the sentence suggested by Matthias Clasen.
Comment 5 Matthias Clasen 2008-08-02 04:46:41 UTC 
2008-08-02  Matthias Clasen  <mclasen@redhat.com>

        Bug 526575 – Missing return type in gtk_ui_manager_get_toplevels
        documentation

        * gtk/gtkuimanager.c (gtk_ui_manager_get_toplevels): Improve
        the docs.