After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526366 - Remove the unused line navigation code from Gecko.py
Remove the unused line navigation code from Gecko.py
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal minor
: 2.24.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-04-05 17:50 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-03-10 00:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
proposed patch (16.75 KB, patch)
2008-04-05 17:53 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-04-05 17:50:00 UTC 
When the Firefox "performance enhancement" work was done, all of the original line navigation code was preserved so that we could easily do performance profiling, track down bugs in the new implementation, etc.  While there are still some kinks that still need to be worked out, we are no longer using the old code.  It should be removed.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-04-05 17:53:14 UTC 
Created attachment 108682 [details] [review]
proposed patch

This has already been regression tested and pylinted and is just ripping out unused code.  That said, "I'm sure it's just fine so I committed it" are proverbial famous last words. :-)  Therefore, please test.

Will, should we also include this for the 2.22 branch?
Comment 2 Willie Walker 2008-04-15 15:51:42 UTC 
(In reply to comment #1)
> Created an attachment (id=108682) [edit]
> proposed patch
> 
> This has already been regression tested and pylinted and is just ripping out
> unused code.  That said, "I'm sure it's just fine so I committed it" are
> proverbial famous last words. :-)  Therefore, please test.
> 
> Will, should we also include this for the 2.22 branch?

Hmmm....I'm not sure.  I'm tempted to say leave it in 2.22 for the sake of keeping that branch relatively stable.
Comment 3 Mike Pedersen 2008-04-18 21:26:09 UTC 
This patch seems to work nicely for me.
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-04-19 04:46:49 UTC 
Thanks Mike.  Patch committed to trunk.  Moving to pending.