Created attachment 111114 [details] [review]
use urllib.urlopen with threads instead of async

This patch removes gnomevfs depencency and adds the following features:
- use tooltip to communicate if invest fails to connect yahoo finance, give some brief information about stocks/positions
- proxy support (use gnome proxy settings if valid, otherwise use system proxy)

Closes also:
- #415237 – invest applets does not retrieve quotes (proxy)

I have no possibility to test the proxy feature, it would be nice to have feedbacks.

*** Bug 543712 has been marked as a duplicate of this bug. ***

Opened by Andre Klapper (reporter, points: 29)
2008-07-19 10:30 UTC [reply]

Also see http://live.gnome.org/GioPort for more information.
Copying from duplicate bug 543712:


./invest-applet/invest/chart.py:import gnomevfs
./invest-applet/invest/chart.py:                gnomevfs.async.open(url, lambda
h,e: self.on_chart_open(h,e,url))
./invest-applet/invest/chart.py:        gnomevfs.async.open(url, open_cb,
gnomevfs.OPEN_READ,
./invest-applet/invest/chart.py:                gnomevfs.PRIORITY_DEFAULT)
./invest-applet/invest/quotes.py:import gtk, gobject, gnomevfs
./invest-applet/invest/quotes.py:              
gnomevfs.async.open(invest.QUOTES_URL % {"s": s[:-1]}, self.on_quotes_open)
./invest-applet/invest/widgets.py:import gtk, gobject, gnomevfs
./invest-applet/invest/about.py:import gtk, gtk.gdk, gnomevfs, gobject
./invest-applet/invest/about.py:        gnomevfs.url_show("mailto:%s" % mail)
./invest-applet/invest/about.py:        gnomevfs.url_show(link)


Comment #1 from Gian Mario Tagliaretti:

In order to completely remove gnomevfs also an unstable release of pygtk is
needed (for gtk_show_uri), I already have a patch for pygtk, I hope I can
finish it in a few days and roll a patch for invest-applet afterwards.

Callum, can we get a review/commit if possible? TIA!

OK, pygtk API is in, see bug 544777. Now we only need a pygtk release...

The patch has numerous minor issues. I hope to be able to merge and fix the patch in the next few days. The most notable issue is that the retrieval of the stock data is not done asynchronously (only the opening of the socket). This should be almost trivial for me to fix.

The patch has been fixed and committed.

Great, thanks everybody! Matteo, also interested in porting disk-mounter (bug 543711)? ;-)

I'm sorry but I have no time in this period and I still have some other changes in mind for invest-applet :)