Bug 524190 – Crash os.mkdirs() in sudoku_maker

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 524190 - Crash os.mkdirs() in sudoku_maker


Summary:	Crash os.mkdirs() in sudoku_maker


Status:	RESOLVED FIXED

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	gnome-sudoku
Version:	2.22.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	GNOME Games maintainers
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Duplicates:	532834 547888 548262 549189 549871 549934 551110 551893 560023 560102 (view as bug list)
Depends on:
Blocks:

Reported:	2008-03-24 20:11 UTC by yl_rockslave
Modified:	2008-11-10 04:57 UTC

See Also:
GNOME target:	---
GNOME version:	2.21/2.22

Attachments
Just try to create the dir and handle the exception on EEXIST (1.24 KB, patch) 2008-04-07 21:44 UTC, Thomas Andersen	committed	Details \| Review

Description yl_rockslave 2008-03-24 20:11:54 UTC

Version: 2.22.0

What were you doing when the application crashed?
Copying lots of music files from my windows vista partition, about 20 gbs worth.


Distribution: Ubuntu 8.04 (hardy)
Gnome Release: 2.22.0 2008-03-17 (Ubuntu)
BugBuddy Version: 2.22.0

System: Linux 2.6.24-12-generic #1 SMP Wed Mar 12 23:01:54 UTC 2008 i686
X Vendor: The X.Org Foundation
X Vendor Release: 10400090
Selinux: No
Accessibility: Disabled
GTK+ Theme: Human-Murrine
Icon Theme: Human

Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0



----------- .xsession-errors ---------------------
    start_game()

+ Trace 193244

File "/var/lib/python-support/python2.5/gnome_sudoku/gnome_sudoku.py", line 21 in start_game
```
main.start_game()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 1039 in start_game
```
u = UI()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 183 in __init__
```
self.sudoku_maker = sudoku_maker.SudokuMaker()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/sudoku_maker.py", line 312 in __init__
```
self.load()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/sudoku_maker.py", line 327 in load
```
os.makedirs(self.pickle_to)
```
File "/usr/lib/python2.5/os.py", line 171 in makedirs
```
mkdir(name, mode)
```

OSError: [Errno 17] File exists: '/home/tony/.gnome2/gnome-sudoku/puzzles'

--------------------------------------------------
Traceback (most recent call last):
  File "/usr/games/gnome-sudoku", line 58, in <module>
    start_game()

+ Trace 193244

File "/var/lib/python-support/python2.5/gnome_sudoku/gnome_sudoku.py", line 21 in start_game
```
main.start_game()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 1039 in start_game
```
u = UI()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 183 in __init__
```
self.sudoku_maker = sudoku_maker.SudokuMaker()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/sudoku_maker.py", line 312 in __init__
```
self.load()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/sudoku_maker.py", line 327 in load
```
os.makedirs(self.pickle_to)
```
File "/usr/lib/python2.5/os.py", line 171 in makedirs
```
mkdir(name, mode)
```

OSError: [Errno 17] File exists: '/home/tony/.gnome2/gnome-sudoku/puzzles'

Comment 1 Thomas Andersen 2008-04-07 21:23:50 UTC

Does the problem continue to happen? Did you open two instances of sudoku at the same time?

Comment 2 Thomas Andersen 2008-04-07 21:44:39 UTC

Created attachment 108817 [details] [review]
Just try to create the dir and handle the exception on EEXIST

Comment 3 Thomas Andersen 2008-04-07 21:46:43 UTC

Enough talk. Let's just fix it instead :) This could happen very rarely when two instances of the game are started at the same time. If the disk is under heavy load the risk of collision is greater.

Fixed on trunk

Comment 4 Thomas Andersen 2008-08-07 01:47:23 UTC

*** Bug 532834 has been marked as a duplicate of this bug. ***

Comment 5 Thomas Andersen 2008-08-17 03:44:55 UTC

*** Bug 547888 has been marked as a duplicate of this bug. ***

Comment 6 Thomas Andersen 2008-08-19 00:34:07 UTC

*** Bug 548262 has been marked as a duplicate of this bug. ***

Comment 7 Gianluca Borello 2008-09-12 08:52:31 UTC

*** Bug 551893 has been marked as a duplicate of this bug. ***

Comment 8 Gianluca Borello 2008-09-12 08:52:38 UTC

*** Bug 551110 has been marked as a duplicate of this bug. ***

Comment 9 Gianluca Borello 2008-09-12 08:52:57 UTC

*** Bug 549934 has been marked as a duplicate of this bug. ***

Comment 10 Gianluca Borello 2008-09-12 08:53:06 UTC

*** Bug 549871 has been marked as a duplicate of this bug. ***

Comment 11 Gianluca Borello 2008-09-12 08:53:12 UTC

*** Bug 549189 has been marked as a duplicate of this bug. ***

Comment 12 Robert Ancell 2008-11-10 04:55:45 UTC

The other exceptions were fixed for 2.24.2:
http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8268
http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8269

Comment 13 Robert Ancell 2008-11-10 04:56:19 UTC

*** Bug 560023 has been marked as a duplicate of this bug. ***

Comment 14 Robert Ancell 2008-11-10 04:57:58 UTC

*** Bug 560102 has been marked as a duplicate of this bug. ***