After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524116 - bookmarks do not show correct names for smb shares
bookmarks do not show correct names for smb shares
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 659536 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-24 13:17 UTC by Sebastien Bacher
Modified: 2012-11-26 13:46 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
unhelpful network bookmarks (7.14 KB, image/png)
2012-08-27 13:20 UTC, William Jon McCann
  Details
Try to store names for bookmarked uris (4.46 KB, patch)
2012-08-28 00:24 UTC, William Jon McCann
committed Details | Review
Set a better file display name by default (6.84 KB, patch)
2012-08-28 14:07 UTC, William Jon McCann
committed Details | Review

Description Sebastien Bacher 2008-03-24 13:17:59 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/196636

"Bookmarks in nautilus have incorrect names for smb shares, after reboot. For example thi will displaye name "smb" instead of "share on server", only after this was accessed name will be correct.

http://launchpadlibrarian.net/12276732/Bildschirmfoto-Videos%20-%20Datei-Browser.png
Bildschirmfoto-Videos - Datei-Browser.png (54.8 KiB, image/png)

This picture will describe it better."
Comment 1 g11024342@trbvm.com 2010-12-30 07:49:15 UTC
This is present in Maverick 10.10 (Gnome 2.32) even with new bookmarks. I don't recall it being like this in older releases though (9.10). Just after you have created a bookmark it has the right name but after a reboot it's just called 'smb'.

After using a bookmark it gets renamed to the correct value. Also, mouse-over on any 'smb' bookmark will show the correct name.
Comment 2 rdeenen 2011-05-27 16:41:47 UTC
Also in Nautilus 3.0.1.1 in Fedora 15
Comment 3 André Klapper 2011-08-11 12:37:32 UTC
[Bumping version number as per comment 2]
Comment 4 g11024342@trbvm.com 2011-08-12 12:43:17 UTC
Why is this bug still "Unconfirmed"?
Comment 5 Cosimo Cecchi 2011-10-20 19:36:11 UTC
*** Bug 659536 has been marked as a duplicate of this bug. ***
Comment 6 William Jon McCann 2012-08-27 13:17:18 UTC
I think this is because gtk bookmarks just store the URI of the location and don't have access to the display-name until it is mounted. This seems like a pretty fundamental problem with the way gtk stores bookmarks.
Comment 7 William Jon McCann 2012-08-27 13:20:53 UTC
Created attachment 222548 [details]
unhelpful network bookmarks
Comment 8 William Jon McCann 2012-08-28 00:24:20 UTC
Created attachment 222598 [details] [review]
Try to store names for bookmarked uris
Comment 9 Cosimo Cecchi 2012-08-28 02:45:18 UTC
Review of attachment 222598 [details] [review]:

Looks good to me, with a minor comment.

::: src/nautilus-window-manage-views.c
@@ +130,3 @@
 
+		if (file != NULL) {
+			display_name = nautilus_file_get_display_name (file);

You can move this to the else block below, as new_location can't be != NULL if file is NULL.
Comment 10 William Jon McCann 2012-08-28 14:07:35 UTC
Created attachment 222635 [details] [review]
Set a better file display name by default
Comment 11 Cosimo Cecchi 2012-08-28 14:12:13 UTC
Review of attachment 222635 [details] [review]:

Looks good
Comment 12 Bastien Nocera 2012-08-28 14:14:54 UTC
The same thing is needed in GTK+ for use in the file chooser, is there a bug for that?
Comment 13 Henning Tegner 2012-11-26 10:28:36 UTC
I've seen this on Ubuntu 12.04.1 with the following components:

rc libnautilus-extension1 1:2.30.1-0ubuntu1.2
ii libnautilus-extension1a 1:3.4.2-0ubuntu5
ii nautilus 1:3.4.2-0ubuntu5
ii nautilus-data 1:3.4.2-0ubuntu5
ii nautilus-sendto 3.0.1-2ubuntu2
ii nautilus-sendto-empathy 3.4.2.3-0ubuntu1
ii nautilus-share 0.7.3-1ubuntu2
Comment 14 Cosimo Cecchi 2012-11-26 13:46:05 UTC
The fix is in Nautilus 3.6 or newer.