After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523633 - Bad error handling in page processing
Bad error handling in page processing
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-03-20 21:05 UTC by Claude Paroz
Modified: 2008-03-26 21:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Catch errors (1.09 KB, patch)
2008-03-20 21:10 UTC, Claude Paroz 		none Details | Review

Description Claude Paroz 2008-03-20 21:05:24 UTC 
When an error occurs in damned-lies, the error page is not suitable for ordinary users. Moreover, the traceback can reveal some internal data (http://mail.gnome.org/archives/gnome-i18n/2008-March/msg00382.html).
Comment 1 Claude Paroz 2008-03-20 21:10:50 UTC 
Created attachment 107705 [details] [review]
Catch errors

Here's a quick patch that catch errors when rendering HTML and display a simple error page instead of a complete traceback. I'd like to see Vivien's screenshot to see if this patch would also have resolved the case he mentioned.
Comment 2 malerba 2008-03-21 07:47:42 UTC 
Created attachment 107726 [details]
Screenshot
Comment 3 Claude Paroz 2008-03-21 18:56:02 UTC 
The error handling code added in rev. 811 should prevent such debug information to be revealed to users. Many thanks Vivien for warning us about this problem.
Comment 4 Wouter Bolsterlee (uws) 2008-03-25 11:44:21 UTC 
I've asked Olav Vitters to remove the attachment, since it contains sensitive information. Reopening to track the status of that.
Comment 5 Claude Paroz 2008-03-26 21:09:17 UTC 
Thanks Olav and Wouter, we can close again 'safely' now.