GNOME Bugzilla – Bug 523507
[PATCH] New database backend based on a coalesced hashtable
Last modified: 2008-03-22 22:11:16 UTC
This is a tracking issue for Jan Heller's patch on the gegl-developer mailing list that introduces a coalesced hash table as the Babl database backend. The thread can be followed here: [Gegl-developer] Hi, need any help? https://lists.xcf.berkeley.edu/lists/gegl-developer/2008-March/000788.html
Created attachment 107659 [details] [review] Jan Heler's patch Here is the patch, let's integrate into Babl. It needs some changes first though.
Here are my comments from the mailing-list: I would prefer if this functionality could be added in new files babl-list.[ch] and babl-hash-table.[ch]. Also the hash-table functions should be prefixed with babl_hash_table_ instead of just babl_hash_ as we should keep the babl_hash prefix for hash functions. Unless Pippin objects, we should IMO get this code into SVN. If someone could do the suggested changes and attach a new patch here, that would help a lot.
Jan I am terriby sorry for misspelling your name, it should be Jan Heller of course
Created attachment 107771 [details] [review] Original patch modified as suggested by Sven
The patch applies cleanly and seems to work nicely. Unless Pippin or anyone else objects, I will commit this to SVN trunk.
2008-03-22 Sven Neumann <sven@gimp.org> Applied patch from Jan Heller that introduces list and hash table functionality and changes the babl database to use coalesced hashing (bug #523507): * babl/Makefile.am * babl/babl-list.[ch] * babl/babl-hash-table.[ch]: new files providing list and hash table functionality. * babl/babl-internal.h: include the new header files. * babl/babl-db.[ch]: use the new code. * babl/babl-fish.c: changed accordingly. Jan, thanks a lot for your contribution. I assume that you will want to continue to work on this and also port the rest of the babl code to the new list API?! Please send your patches to the mailing-list or open a new bug report and attach them there.