After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522797 - Orca should not speak false "inaccessible" messages when switching applications
Orca should not speak false "inaccessible" messages when switching applications
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.22.x
Other All
: Normal normal
: 2.22.1
Assigned To: Rich Burridge
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-16 17:58 UTC by Mike Pedersen
Modified: 2008-04-29 19:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Revision #1. (1.33 KB, patch)
2008-04-24 18:12 UTC, Rich Burridge
reviewed Details | Review
Revision #2. (1.35 KB, patch)
2008-04-28 15:34 UTC, Rich Burridge
committed Details | Review
Extra patch for speaking the brackets around the object name when the window is iconified. (458 bytes, patch)
2008-04-28 15:41 UTC, Rich Burridge
committed Details | Review

Description Mike Pedersen 2008-03-16 17:58:30 UTC
1.  Open several applications such as openoffice, firefox, gedit and terminal.  
2.  switch workspaces and open some more applications. 
3.  alt+tab between applications or switch workspaces.  
You should notice that frequently when the application first gains focus we hear "application name inaccessible".  I had some users at CSUN comment that they found this quite confusing at times.
Comment 1 Willie Walker 2008-04-01 20:50:27 UTC
Mike is going to work up an exact set of steps to help us reproduce this since we're all having trouble reproducing it.  :-(
Comment 2 Mike Pedersen 2008-04-02 20:03:11 UTC
Since my update to hardy I'm now not getting this nearly as much.  Lets just leave this open and I'll add comments when I have more information. 
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-04-03 21:28:46 UTC
Aha.

1. Launch several apps

2. Press Control+Alt+D (Ubuntu) or Meta+D (Solaris)

(Note that everything in the window list now has square brackets around its name)

3. Alt+Tab into one of the open windows

(We say it's inaccessible, but the brackets are gone from that item)

4. Alt+Tab into one of the other open winodws

(ditto)

5. Alt+Tab into one of the window from step 3

(we don't say inaccessible)

Brackets are bad.... ;-)

(Not sure what brackets mean, what events and statuses we do and don't have, etc.  Just pointing out a reproducible case. :-) )
Comment 4 Willie Walker 2008-04-15 20:34:36 UTC
In the team meeting today, we discovered that this seems to be the result of running into a window that's been iconified.  Those windows end up having "[" and "]" around the name, and that's probably what's causing metacity.py to not find a match.
Comment 5 Rich Burridge 2008-04-24 18:12:22 UTC
Created attachment 109843 [details] [review]
Revision #1.

This seems to fix the problem. Please test.
Comment 6 Willie Walker 2008-04-24 18:30:49 UTC
(In reply to comment #5)
> Created an attachment (id=109843) [edit]
> Revision #1.
> 
> This seems to fix the problem. Please test.

Seems to work nicely, and in looking at the ui/tabpopup.c code of metacity, it looks like the assumption that "[" and "]" will be used for all locales is safe.  The only question I have is whether we want to strip the "[" and "]" from the presentation.  That is, these are being displayed, so I'm not sure we really want to strip them out.  That's a question for Mike, though.
Comment 7 Mike Pedersen 2008-04-25 17:38:32 UTC
This patch fails for me at line 5.  

To the above question.  If the "[" is on the screen we should not strip it.  
Comment 8 Rich Burridge 2008-04-28 15:34:54 UTC
Created attachment 110045 [details] [review]
Revision #2.

I took the diffs from the wrong directory. Here is a correct one. From
Will's last comment, I've gone ahead and committed the patch to SVN
trunk and the gnome-2-22 branch. Moving the bug to "[pending]".

When you Alt-Tab through the running applications, and the windows are
iconified, then the popup window on the screen shows the application
name surrounded by brackets. From comment #3, Joannie says "brackets are
bad". Are these the ones you'd like spoken Mike? If so, then I'll adjust 
the code to do that.
Comment 9 Rich Burridge 2008-04-28 15:41:53 UTC
Created attachment 110046 [details] [review]
Extra patch for speaking the brackets around the object name when the window is iconified.

From rereading the comments, i can see this is exactly what Will and
Mike were on about, so I've gone ahead and committed this small adjustment
to SVN trunk and the gnome-2-22 branch. Moving the bug to "[pending]".

Please let me know if there are any other adjustments needed.

Thanks.