GNOME Bugzilla – Bug 521082
Replace glade with gtkbuilder
Last modified: 2008-03-15 22:56:46 UTC
Upcoming patch removes dependency on libglade (which is deprecated) for all the applets and uses gtkbuilder instead. I think it would be good to get this in when the branch for 2.22 gets made.
Created attachment 106804 [details] [review] Patch changing glade to gtkbuilder
The patch generally looks good, but the changes it makes to configure.in seem to be changing the system-tools-backends tests for the modemlights applet. Is this a different change you've made thats leaked into this patch? Two minor issues: the patch seems to affect GNOME_MiniCommanderApplet.server, which is a generated file and stickynotes.glade seems to be rewritten as part of the patch. Neither of these are a big problem and are trivial to fix up after the patch is applied. Aside from that I'm ready to commit it.
(In reply to comment #2) > The patch generally looks good, but the changes it makes to configure.in seem > to be changing the system-tools-backends tests for the modemlights applet. Is > this a different change you've made thats leaked into this patch? Sorry that should not have been part of the patch. Please remove it > Two minor issues: the patch seems to affect GNOME_MiniCommanderApplet.server, > which is a generated file and stickynotes.glade seems to be rewritten as part > of the patch. Neither of these are a big problem and are trivial to fix up > after the patch is applied. GNOME_MiniCommanderApplet.server should not be in SVN in my opinion because it get's generated. That's why it ended up in the patch :-( NOTE that there are GNOME_MiniCommanderApplet.server.in files in SVN (one in src and one in the root of minicommander). Looking at the comments it's for some reason, but it seems weird to me The glade file had a mistake the MenuSeperators were set as normal menuitems with no text. gtk-builder-convert choked on that. So I fixed up the glade file > Aside from that I'm ready to commit it. > Can you make the required changes. I won't have access to SVN the coming days. Thanks
OK, I've fixed everything up and committed it. I'm a little worried that generating the .ui files from the .glade files isn't part of the build process. After all, the glade files are the ones that can be easily edited and are marked for translation. Hopefully glade-3 will support gtkbuilder files soon and we can ignore the issue. I had to add the libxml flags to stickynotes because it had been indirectly getting the libxml stuff through libglade. GNOME_MiniCommanderApplet.server shouldn't have been in SVN, its a remnant from before the .in days. I've removed it from SVN. I've also removed all the .glade files. The two GNOME_MiniCommanderApplet.server.in files are there so that by default deskbar applet is run instead of mini-commander. If you really want mini-commander then the second file gets installed and mini-commander is run.
Thanks The glade designer guys have the plan to add builder support now for the 2.24 release. So by then we should be able to remove the glade files