After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519545 - gtk-demo/role_label.py regression test #2 produces the wrong results.
gtk-demo/role_label.py regression test #2 produces the wrong results.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
: 519546 519549 519550 (view as bug list)
Depends on:
Blocks: 519271
 
 
Reported: 2008-02-29 15:40 UTC by Rich Burridge
Modified: 2008-03-05 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revision #1 (7.83 KB, patch)
2008-03-05 18:21 UTC, Rich Burridge 		none Details | Review

Description Rich Burridge 2008-02-29 15:40:34 UTC 
This is on latest Ubuntu Hardy:

EXPECTED:
     "BUG? - text is selected but not presented as such in speech or braille",
     "BRAILLE LINE:  'gtk-demo Application Information Alert This message box has been popped up the following",
     "number of times: Label'",
     "     VISIBLE:  'This message box has been popped', cursor=1",
     "SPEECH OUTPUT: 'This message box has been popped up the following",
     "number of times:'",
     "SPEECH OUTPUT: 'label'",
ACTUAL:
     "BRAILLE LINE:  'gtk-demo Application Information Alert This message box has been popped up the following $l'",
     "     VISIBLE:  'This message box has been popped', cursor=1",
     "SPEECH OUTPUT: 'This message box has been popped up the following",
     "number of times:'",
     "SPEECH OUTPUT: 'label'",
[FAILURE WAS EXPECTED - LOOK FOR BUG? IN EXPECTED RESULTS]

We need to investigate why the selected text is not presented as such in 
speech or braille.
Comment 1 Rich Burridge 2008-03-05 18:13:47 UTC 
*** Bug 519546 has been marked as a duplicate of this bug. ***
Comment 2 Rich Burridge 2008-03-05 18:16:25 UTC 
*** Bug 519549 has been marked as a duplicate of this bug. ***
Comment 3 Rich Burridge 2008-03-05 18:17:14 UTC 
*** Bug 519550 has been marked as a duplicate of this bug. ***
Comment 4 Rich Burridge 2008-03-05 18:21:14 UTC 
Created attachment 106634 [details] [review]
Revision #1

Patch hopefully fixing the problems in regression tests 2, 3, 6 and 7.
Note that for a ROLE_LABEL we were using the _speakGenericObject() method
which doesn't test for selected text.

I've created a new _speakLabel() for ROLE_LABEL's now.

I've also created a new _getSpeechForAllTextSelection() method as we
are now using similar code for spin button and label text selection,
and adjust their _speak...() methods to call this.

For the role_label.py regression tests, just test #5 is still failing
(to be investigated).
For the role_spin)button.py, regression tests, test #2 remains fixed.
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-03-05 19:22:13 UTC 
This works for me (both functionally and the regression test - sans test#5).
Comment 6 Rich Burridge 2008-03-05 19:40:12 UTC 
Thanks Joanie. Patch committed to SVN trunk. Closing as FIXED.