After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519541 - gtk-demo/role_icon.py regression test #2 produces the wrong results.
gtk-demo/role_icon.py regression test #2 produces the wrong results.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
: 519542 (view as bug list)
Depends on:
Blocks: 519271
 
 
Reported: 2008-02-29 15:29 UTC by Rich Burridge
Modified: 2008-03-07 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revision #1 (2.37 KB, patch)
2008-03-05 20:30 UTC, Rich Burridge 		none Details | Review
Revision #2 (6.90 KB, patch)
2008-03-06 19:21 UTC, Rich Burridge 		committed Details | Review

Description Rich Burridge 2008-02-29 15:29:41 UTC 
This is on latest Ubuntu Hardy:

EXPECTED:
     "BUG? - should we present the number of items in the layered pane?",
     "BRAILLE LINE:  'gtk-demo Application GtkIconView demo Frame ScrollPane LayeredPane'",
     "     VISIBLE:  'LayeredPane', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'layered pane'",
ACTUAL:
     "BRAILLE LINE:  'gtk-demo Application GtkIconView demo Frame ScrollPane LayeredPane'",
     "     VISIBLE:  'LayeredPane', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'layered pane'",
[FAILURE WAS EXPECTED - LOOK FOR BUG? IN EXPECTED RESULTS]

We need to determine if we should present the number of items in the 
layered pane.
Comment 1 Rich Burridge 2008-03-05 20:30:29 UTC 
Created attachment 106640 [details] [review]
Revision #1

Assuming that this is what we want (Will's BUG? comment was
should we present the number of items in the layered pane?)
then this patch adds "<N> items" as the last thing spoken
for a single-press "where am I" KP_Enter.
Comment 2 Rich Burridge 2008-03-06 17:58:01 UTC 
*** Bug 519542 has been marked as a duplicate of this bug. ***
Comment 3 Rich Burridge 2008-03-06 17:59:27 UTC 
Commentary from Mike in bug #519542:

'After thinking about this I think a user pressing the WhereAmI key 
would always want to know the number of items selected.  I think 
"m of n items selected" is the way to go.'

I'll adjust the patch here to do that, and fixup role_icon.py
regression tests #2 and #4 to match.
Comment 4 Rich Burridge 2008-03-06 19:21:48 UTC 
Created attachment 106709 [details] [review]
Revision #2

This now produces the expected results when run on Ubuntu Hardy.
Comment 5 Rich Burridge 2008-03-06 19:23:55 UTC 
This also fixes up the output for test #7, so perhaps bug #519543
should be adjusted to specifically handle the case of creating
a special directory and adjusting the test to use that...
Comment 6 Rich Burridge 2008-03-07 21:34:15 UTC 
Patch committed. Closing as FIXED.

Bug #519543 will be the one where the role_icon.py regression
tests are updated to use a special directory that hopefully
resolves the Solaris/Ubuntu differences.