GNOME Bugzilla – Bug 519360
Add confirmation on exit
Last modified: 2021-05-26 09:58:12 UTC
Add a confirmation dialogue on exit even if no data needs to be saved (or Dasher is in a mode where it does not have an internal document). This should be configurable as per #519357.
Hey, if no ones working on this, I'd like to give it a shot, seems like a good way to wet might feet with dasher.
Created attachment 109666 [details] [review] Dasher Exit Dialog This adds a simple exit prompt whenever dasher is about to exit, not just when the file has changed. Probably needs some formatting/translation love. (I've never used gtkmm before and added 3 new strings)
Thanks - I've applied the patch to trunk and confirmed that Dasher compiles, although I'm currently connecting over SSH so can't test it out properly. Would you be willing to take a look at #519357? I'd suggest adding a boolean parameter to Src/Common/AppSettingsHeader.h and Src/Common/AppSettingsData.h and making this dialogue box appear only when that is set. Let me know if you need any more info, as the configuration options code can be a little difficult to work with at times.
I'll look at it, but might need some help ;)
Created attachment 110250 [details] [review] Updated with config option Utilizes a config option, defaults to true.
Hi All: What's the status of this bug? Does the attached patch resolve it? If so, can we get it checked in? Will
Yes. Does the attached patch resolve it? Thank you
Hey! I don't know if this patch is much good anymore (its pretty old). It would be a great help if someone could try applying it against trunk and share the results.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/dasher/-/issues/ Thank you for your understanding and your help.