After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519232 - iagno cannot show menu strings on Japanese locales
iagno cannot show menu strings on Japanese locales
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: iagno
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-28 09:40 UTC by Takao Fujiwara
Modified: 2009-12-11 02:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Snapshot of this problem (25.61 KB, image/png)
2008-02-28 09:41 UTC, Takao Fujiwara 		  Details
Patch for iagno/gnothello.c (952 bytes, patch)
2008-02-28 09:43 UTC, Takao Fujiwara 		needs-work Details | Review
Screenshot (88.24 KB, image/jpeg)
2008-03-03 12:26 UTC, mars1 		  Details

Description Takao Fujiwara 2008-02-28 09:40:32 UTC 
iagno cannot show menu strings on Japanese locales.

To reproduce:
1. Invoke iagno on ja_JP.UTF-8.

Then menu strings are not shown completely.
I'm attaching the snapshot and the patch.
Comment 1 Takao Fujiwara 2008-02-28 09:41:20 UTC 
Created attachment 106141 [details]
Snapshot of this problem
Comment 2 Takao Fujiwara 2008-02-28 09:43:06 UTC 
Created attachment 106142 [details] [review]
Patch for iagno/gnothello.c

It seems a regression of bugzilla 426246.
After I copied the code of gtk_window_configure_event() in gtk/gtkwindow.c into gnome-games/iagno/gnothello.c, this problem does not occur.

gdk_window_thaw_toplevel_updates_libgtk_only() is needed for Japanese locales as the attached patch.
Comment 3 Andreas Røsdal 2008-03-01 18:42:17 UTC 
I tried the patch in comment #2, and when setting LANG=ja_JP.UTF-8
the menus are still shown in English, not Japanese as I would expect.
Comment 4 Takao Fujiwara 2008-03-03 07:40:16 UTC 
Probably you don't have the translated message files.
I can see the localized mene items with this patch.

I reopened the bug since the patch is not integrated yet.
Comment 5 mars1 2008-03-03 12:26:22 UTC 
Created attachment 106462 [details]
Screenshot

I reported for this bug in bug 444602 comment #61.
and I made a patch in there too.
Please see screen shot.
My system is Fedora 8, gnome 2.20.3 and ggz 0.0.14.1.
Comment 6 Takao Fujiwara 2008-03-04 14:32:44 UTC 
The patch of bug 444602 is interesting.

--- gnome-games-2.21.92/iagno/gnothello.c.orig  2008-03-04 23:27:10.131406000 +0900
+++ gnome-games-2.21.92/iagno/gnothello.c       2008-03-04 23:28:45.659982000 +0900
@@ -644,7 +644,7 @@ create_window (void)
                               BOARDWIDTH, BOARDHEIGHT);
   g_signal_connect (G_OBJECT (drawing_area), "expose_event",
                    G_CALLBACK (expose_event), NULL);
-  g_signal_connect (G_OBJECT (window), "configure_event",
+  g_signal_connect (G_OBJECT (drawing_area), "configure_event",
                    G_CALLBACK (configure_event), NULL);
   g_signal_connect (G_OBJECT (drawing_area), "button_press_event",
                    G_CALLBACK (button_press_event), NULL);

The patch also can fix this bug.

Either my patch or this patch is ok with me.
Comment 7 Jesse Zhang 2009-12-10 15:07:09 UTC 
This is not happening any more, is it? "LANG=zh_CN.UTF-8 iagno" works ok for 2.28.1.
Comment 8 Takao Fujiwara 2009-12-11 02:00:23 UTC 
Yes, this is no longer reproduced.
I confirmed Fedora and OpenSolaris.
Comment 9 Jesse Zhang 2009-12-11 02:10:39 UTC 
Fixed per reporter's comment. Closing.