GNOME Bugzilla – Bug 519090
Add accessibility support to GtkScaleButton
Last modified: 2009-02-26 07:55:24 UTC
The GtkScaleButton is a newer widget for GTK+ and we need accessibility support created for it.
As commented in bug #519092, I'd like to continue my work on this widget. May I start?
Go for it! :-) Thanks!
Created attachment 110278 [details] [review] Adds a subclass of GailButton, which implements AtkAction and AtkValue.
Neat! Li - can you review this patch, please? Jan - where in the wild can I find a GtkScaleButton to test this with (e.g., is there one in gtk-demo somewhere)?
Oh, sorry. I think I missed the patch because of the vacation. Too many mails... I will review it today.
Very good patch. I am testing it next week.
It tested it with the GtkVolumeButton (subclass of GtkScaleButton) from totem.
I failed to grab the button with GOK. Seems the VolumeButton only show when totem is on the top of the desktop, but gok always make itself as the top window. Similar thing happens with accerciser, I cannot do anything with accerciser because any operation will cause totem lose focus.
Li, rhythmbox can be built with HAVE_GTK_VOLUME_BUTTON to give you another testcase. The patch looks ok to me. But I thought the general idea was to add new a11y implementations in gtk itself ?
The patch include some gail header files. If add gailscalebutton in gtk, it may cause gtk link to gail library. Will it cause any problem?
One comment, we should include gtk/gtk.h instead of gtk/gtkaccessible.h to avoid build error.
> The patch include some gail header files. If add gailscalebutton in gtk, it may > cause gtk link to gail library. Will it cause any problem? Ah. Yeah, that won't work. We'd have to move GailButton to gtk first. Lets just keep it in gail for now then.
(In reply to comment #12) > > The patch include some gail header files. If add gailscalebutton in gtk, it may > > cause gtk link to gail library. Will it cause any problem? > > Ah. Yeah, that won't work. We'd have to move GailButton to gtk first. > > Lets just keep it in gail for now then. GAIL is now in GTK+ :-) - is the attached patch (or a revised form of it) now something that can be considered?
This is not blocking on my review is it ? Patch looks fine to me (without testing it)
Created attachment 129548 [details] [review] patch
Committed. Thanks for your patch Jan!