GNOME Bugzilla – Bug 518727
Possible data loss due to UI problem ("All" topic being rename-able)
Last modified: 2014-11-22 10:36:19 UTC
Turns out you can trick the bookmarks editor to rename the All topic. This of course is not good, it's even worse when I lost my bookmarks because I renamed the topic lots of time without noticing what was happening. To reproduce: 1. open bookmark editor, 2. type something in search entry, 3. click file > new topic, 4. type your name and drop your jaw as you see All topic renamed I'm unable to reproduce the data loss, but it happened and it sucked :). Some warnings were printed after it on the console, but I was too desperate to take note of them.
Reality check.
Created attachment 162039 [details] [review] Fix new bookmark topic addition when search entry is not empty. Possible patch. I'm not sure is this a walk-around or a solution. It looks like gtk_tree_model_sort_convert_child_iter_to_iter() (in ephy_node_view_select_node()) returns different iterator then expected if search entry is not empty.
Created attachment 177431 [details] [review] ephy-bookmarks-editor: fix new topic selection bug When the search entry is not empty and "New topic" is activated from the menu, the "All" topic will set for renaming instead of the new "Type a topic" node. This can cause serious data loss. Bug #518727 Signed-off-by: Diego Escalante Urrelo <descalante@igalia.com>
Comment on attachment 177431 [details] [review] ephy-bookmarks-editor: fix new topic selection bug Leaving open for a proper fix someday. Attachment 177431 [details] pushed as 876c61d - ephy-bookmarks-editor: fix new topic selection bug
This bug does not appear to exist in 3.8.2: I cannot duplicate it.
Still can't reproduce in 3.14.2 so closing as obsolete.