After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516758 - [PATCH] Port to gio
[PATCH] Port to gio
Status: RESOLVED DUPLICATE of bug 546060
Product: gtksourceview
Classification: Platform
Component: General
git master
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-15 22:30 UTC by Michael Terry
Modified: 2008-08-03 07:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch, gnome-vfs -> gio (10.34 KB, patch)
2008-02-15 22:30 UTC, Michael Terry 		none Details | Review

Description Michael Terry 2008-02-15 22:30:07 UTC 
Attached is a patch to port gtksourceview (really, just test-widget) to gio, our new file I/O overlords.

As well as just a straight port, I used GFile more extensively in the code so that now test-widget can take URIs in addition to file paths.
Comment 1 Michael Terry 2008-02-15 22:30:58 UTC 
Created attachment 105353 [details] [review]
Proposed patch, gnome-vfs -> gio
Comment 2 Paolo Borelli 2008-03-08 13:46:54 UTC 
thanks for the patch... given that gnome-vfs is just an optional dep for the test program I am not in a hurry to commit this since right now it would mean more ifdeffing (I do not want to bump the glib requirement just for this).

Let's wait for the next developement cycle
Comment 3 André Klapper 2008-06-05 15:03:17 UTC 
paolo: *ping* - can this go in now?
Comment 4 Yevgen Muntyan 2008-06-06 02:35:54 UTC 
Why not simply replace gnomevfs with gio, i.e. make it optional? I/O overlords get their lamb, yet there won't be a hard dependency on new glib.
Comment 5 Paolo Borelli 2008-06-06 18:36:35 UTC 
well, actually at some point I was planning to introduce gtk_source_language_manager_ger_language_from_content_type (yay for short names...) which would require gio.

But for now sure I would not mind make the use of gio conditional as  it is now, though it just seems like a silly exercise: gtksourceview itself does not really depend on gio or gnome-vfs
Comment 6 André Klapper 2008-06-22 16:19:49 UTC 
i'd really appreciate substituting the optional gnome-vfs dependency by an optional gvfs/gio dependency to clean up our stack, apart from any other long-term plans like gtk_source_language_manager_ger_language_from_content_type.
Comment 7 Yevgen Muntyan 2008-08-03 07:48:03 UTC 

*** This bug has been marked as a duplicate of 546060 ***