After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516620 - [0.4.2] GalleryExport makefile tries to delete /usr/lib/f-spot/extensions/GalleryExport.addin.xml
[0.4.2] GalleryExport makefile tries to delete /usr/lib/f-spot/extensions/Gal...
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.4.x
Other All
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 522031 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-15 07:00 UTC by Maia Everett
Modified: 2008-03-12 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Actually respect $(DESTDIR). (539 bytes, patch)
2008-03-09 01:44 UTC, Tim Retout 		none Details | Review

Description Maia Everett 2008-02-15 07:00:53 UTC 
Please describe the problem:
When building F-Spot with a diverted DESTDIR (for example, when building a Debian package for it), the build process fails in extensions/GalleryExport during install phase:

rm -f /usr/lib/f-spot/extensions/GalleryExport.addin.xml

Steps to reproduce:
1. Execute configure and make
2. Try executing make install as a normal user with a diverted DESTDIR, for example, DESTDIR=/tmp/f-spot

Actual results:
Installation tries to delete /usr/lib/f-spot/extensions/GalleryExport.addin.xml and fails because the user is not root.

Expected results:
Installation tries to delete (DESTDIR)/usr/lib/f-spot/extensions/GalleryExport.addin.xml and succeeds, because this file either doesn't exist or is deletable by a normal user.

Does this happen every time?
Yes.

Other information:
Comment 1 Stephane Delcroix 2008-02-15 08:30:58 UTC 
fixed in r3681
Comment 2 Tim Retout 2008-03-09 01:44:39 UTC 
Created attachment 106877 [details] [review]
Actually respect $(DESTDIR).

The fix committed didn't actually solve the problem - the custom install hook is still looking at entirely the wrong file. If a user left the wrong permissions on the installed XML file, then it would get deleted accidentally.

Here is a better fix.
Comment 3 Stephane Delcroix 2008-03-09 07:59:23 UTC 
fixed in r3743
Comment 4 Maxxer 2008-03-12 15:05:59 UTC 
*** Bug 522031 has been marked as a duplicate of this bug. ***