GNOME Bugzilla – Bug 516585
bashisms in f-spot-sqlite-upgrade
Last modified: 2008-02-20 13:01:23 UTC
Certain shell constructs are used in f-spot-sqlite-upgrade which are specific to bash; if any other shell is used as /bin/sh (such as 'dash' in Ubuntu and hopefully in Debian lenny), then the script will not work as expected. Here is the output of checkbashisms: $ checkbashisms tools/f-spot-sqlite-upgrade possible bashism in tools/f-spot-sqlite-upgrade line 11 (should be >word 2>&1): if ! which sqlite >& /dev/null ; then possible bashism in tools/f-spot-sqlite-upgrade line 14 (should be >word 2>&1): elif ! which sqlite3 >& /dev/null ; then possible bashism in tools/f-spot-sqlite-upgrade line 29 (should be >word 2>&1): if grep "^...This file contains an SQLite 2.1 database" $DB_LOCATION &> /dev/null; then (Reported as http://bugs.debian.org/464652 in Debian.)
Created attachment 105295 [details] [review] Trivial patch to replace >& /dev/null with >/dev/null 2>& in three places.
Um, I got that description wrong just now, because it's half midnight here. Obviously I meant 2>&1, and I just noticed one place used &> and not >&. Still, I think the patch is right. :)
fixed in r3700