After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516321 - Caps lock not correctly reporting the state when toggled
Caps lock not correctly reporting the state when toggled
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.21.x
Other All
: Normal minor
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-13 23:46 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
revision 1 (593 bytes, patch)
2008-02-14 00:01 UTC, Joanmarie Diggs (IRC: joanie) 		none Details | Review
Patch to add META as well and also adjust comment (899 bytes, patch)
2008-02-16 02:52 UTC, Willie Walker 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-02-13 23:46:29 UTC 
As reported by Steve on the Orca list, we now always say caps lock is "on" when it is toggled on and off.

Daniel Dalton since narrowed it down to the triple click uber patch.  (Thanks Daniel!!)

Patch to follow.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-02-14 00:01:24 UTC 
Created attachment 105190 [details] [review]
revision 1

This seems to do the job for desktop layout and still allows one to bind/rebind and use single and multi-click Caps Lock commands in laptop layout.  Please test.
Comment 2 Willie Walker 2008-02-16 02:51:09 UTC 
(In reply to comment #1)
> Created an attachment (id=105190) [edit]
> revision 1
> 
> This seems to do the job for desktop layout and still allows one to bind/rebind
> and use single and multi-click Caps Lock commands in laptop layout.  Please
> test.
> 

This seems to do fine.  In looking at the patch, I see that pyatspi.MODIFIER_META and pyatspi.MODIFIER_NUMLOCK are also missing.  So, I'm guessing getting rid of NUMLOCK is intentional since it is so poorly behaved, but META was also an accident similar to SHIFTLOCK.
Comment 3 Willie Walker 2008-02-16 02:52:29 UTC 
Created attachment 105366 [details] [review]
Patch to add META as well and also adjust comment

Seems to work OK.  Will run with the gtk-demo regression tests in a bit.
Comment 4 Willie Walker 2008-02-16 03:53:37 UTC 
(In reply to comment #3)
> Created an attachment (id=105366) [edit]
> Patch to add META as well and also adjust comment
> 
> Seems to work OK.  Will run with the gtk-demo regression tests in a bit.
> 

The gtk-demo regression tests work well, it pylints to a 10.0. CapsLock works, and I can rebind keys to use the Meta key (e.g., the "Windows" key).  I say commit if you think it's good.
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-02-19 01:23:26 UTC 
Thanks Will.  Patch committed.  Moving to pending.