After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516187 - adding gst_collect_pads_read_buffer () collectpads
adding gst_collect_pads_read_buffer () collectpads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal enhancement
: 0.10.18
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on: 516395
Blocks:
 
 
Reported: 2008-02-13 07:43 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2008-02-15 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implementation (2.84 KB, patch)
2008-02-14 09:46 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2008-02-13 07:43:08 UTC 
I would like to add 
GstBuffer * gst_collect_pads_read_buffer(GstCollectPads *pads,
                                                         GstCollectData *data,
                                                         guint size)
to GstCollectPads. It should cfreate a subbuffer. This would allow the callee to also get access to buffer-flags. I need this to make adder GAP-aware (that is skip mixing for sparse streams).

Any thought. better ideas for API name?
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-02-14 09:46:59 UTC 
Created attachment 105214 [details] [review]
implementation
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-02-14 09:47:45 UTC 
I named it gst_collect_pads_take_buffer() as it is kind of similar to gst_adapter_take_buffer
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2008-02-15 13:14:57 UTC 
2008-02-15  Stefan Kost  <ensonic@users.sf.net>

	* docs/libs/gstreamer-libs-sections.txt:
	* libs/gst/base/gstcollectpads.c:
	* libs/gst/base/gstcollectpads.h:
	  Add sub-buffer functions to collectpads. Fixes #516187.
	  API: gst_collect_pads_take_buffer(), gst_collect_pads_read_buffer()