GNOME Bugzilla – Bug 514836
Importing contact lists into a attendee lists for a meeting broken
Last modified: 2013-09-14 16:49:56 UTC
Please describe the problem: I have a contact list for a committee I run with entries of the form: John Doe,Mr. <email@somewhere.org> I can use the contact list in regular email, but when I use it in the attendee list I get double the expected number of entries; i.e., for my example John Doe and Mr. <email@somewhere.org> Clearly something isn't being parsed correctly. Steps to reproduce: 1. Calendar->New->Meeting 2. In the gui, Attendees->Contact Lists (select a contact list with the form above). Notice that everything looks ok at this point 3. Save 4. Reopen the meeting. Actual results: Expected results: Does this happen every time? yes Other information: I'm running a patched e-d-s, patched by Milan Crha to deal with a problem with creating contact lists with entries obtained from a GAL. See BUG 489043 for details.
John Doe,Mr. <email@somewhere.org> is not a valid email address. try "John Doe,Mr. <email@somewhere.org>" and report back, please.
Hi Andre, Have a look at BUG 489043. The contact list in question was created by importing from our GAL. There has been a bug here and the expression without quotes is what Milan's patch gives. I don't see how to edit the contact list once it's created, and in any event, I need the GAL to populate the list initially. As I reported, when I use the contact list in an e-mail, this problem doesn't occur, so the email address can't be "that" invalid. Have I not understood what you want? David
Created attachment 105223 [details] [review] proposed eds patch for evolution-data-server; This is what I thought about, obsoleting EVC_X_DEST_EMAIL, EVC_X_DEST_NAME. It just doesn't make sense to have it there. With these patches (yeah, they are 3 now) it works even without the patch from bug #489043 comment #22, but I believe it is still usable.
Created attachment 105225 [details] [review] proposed evo patch for evolution;
Created attachment 105226 [details] [review] proposed eex patch for evolution-exchange;
I applied all 3 patches to 2.21.91. The problem seems to be fixed. Thanks Milan!
I strongly feel that Ross need to vouch this and bug #489043 . Specially if we want to take it late for 2.21.92
Changing to eds/contacts, because the core change is there.
Milan, I've never really looked at e-destination (it's patched out of eds-dbus!), can you explain the rationale behind the eds patch?
Sure, I can try to explain it. Basically, I obsoleted EVC_X_DEST_NAME and EVC_X_DEST_EMAIL vCard parameters and instead of them I started to use real attribute values, not the one managed only by Evolution. I believe that this is the right thing, because other software will not change our parameters, but those real values only.
Okay, sounds reasonable.
Thanks Ross for your timely review. Milan just get this in for 2.21.92.
eds part committed to trunk. Committed revision 8521. evo part committed to trunk. Committed revision 35072. eex part committed to trunk. Committed revision 1579.
Just for a record, the eds and eex patches contain bug, see bug #518569 for more details. Thanks Akhil to find this out.
Created attachment 105929 [details] New screenshot of brokien attendee list
OK, I'd manually applied Milan's 3 patches and all seemed well. Today I tried building 2.21.92. Have encountered several problems: 1. GAL is broken again 2. Get hangs in new mail on entering To: if exchange account is on. 3. Existing meeting attendee lists (created with Milan's patches in place in 2.21.91) are corrupted. I've attached a screenshot.
I can confirm point 3 for build 2.21.92. See bug 518744. Can we reopen this issue?
I would rather keep it on your bug, we are looking what is the issue, seems like something with libical, but I do not want to make quick decisions.